This repository was archived by the owner on Nov 9, 2024. It is now read-only.
Singleton now works when Tippys are added #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks! |
Contributor
Author
|
@atomiks Great to have this merged in. Looking forward to this change being released to npm and then I can get rid of my fork! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR updates the singleton logic so that
setInstancesis called when Tippys are added or removed.This means that you can now dynamically add Tippys when you have a singleton (previously all Tippys needed to be declared when creating the singleton).
This should fix the issue raised here:
#253
@atomiks Let me know if you want any tweaks to this MR before merging it (e.g. more tests, docs changes, etc).