Add log client implementation #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuujo
reviewed
Feb 4, 2020
pkg/client/log/log.go
Outdated
| type Index uint64 | ||
|
|
||
| // Version is the version of an entry | ||
| type Version uint64 |
Member
There was a problem hiding this comment.
We don’t need a version because entries are immutable. Versions are only needed for optimistic locking when updating objects.
pkg/client/log/log.go
Outdated
| Remove(ctx context.Context, index int64, opts ...RemoveOption) (*Entry, error) | ||
|
|
||
| // Len returns the number of entries in the log | ||
| Len(ctx context.Context) (int, error) |
Member
There was a problem hiding this comment.
It seems like Size would be more appropriate if this is the number of entries. Len feels like it would be equal to LastIndex.
adibrastegarnia
force-pushed
the
log_primitive_client
branch
from
24ff723 to
c5f89ff
Compare
adibrastegarnia
force-pushed
the
log_primitive_client
branch
from
f3b7b63 to
3715ca5
Compare
Member
|
lgtm |
kuujo
approved these changes
Feb 7, 2020
adibrastegarnia
force-pushed
the
log_primitive_client
branch
from
d72b82c to
a415573
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.