bigint: misc fixes #1920
Merged
bigint: misc fixes #1920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bettio
force-pushed
the
bigint-fixes
branch
2 times, most recently
from
14c7f13 to
39d06ad
Compare
make_bigint calls `intn_count_digits` as first step, so if bigres_len exceeds actual buffer length, `intn_count_digits` reads out-of-bounds. Signed-off-by: Davide Bettio <davide@uninstall.it>
Make it available project-wide as util function, and rename it for the sake of clarity. Signed-off-by: Davide Bettio <davide@uninstall.it>
Function was using num_bytes in SMALL_BIG_EXT case when estimating heap consumption: the correct input is roughly `num_bytes / sizeof(digit) + align_padding`. Also add `intn_required_digits_for_unsigned_integer` for this purpose to intn.h. This change required newly introduced `size_align_up_pow2` in utils.h. Signed-off-by: Davide Bettio <davide@uninstall.it>
Integers length is compared before comparing digits. Signed-off-by: Davide Bettio <davide@uninstall.it>
Use INTN_DIGIT_BITS instead of `sizeof(intn_digit_t) * 8`. Signed-off-by: Davide Bettio <davide@uninstall.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those bugs were unlikely causing a crash, but still code wasn't correct.
As an additional change: add
size_align_up_pow2and similar utilities toutils.hsince they are also required in intn.h as well.These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later