Skip to content

Conversation

@pguyot
Copy link
Collaborator

@pguyot pguyot commented Nov 27, 2022

This PR is a step towards OTP25 support. OTP25 doesn't use these opcodes but bs_create_bin/6 needs the primitives that were missing for utf encoding.

Add support for the following opcodes

  • bs_utf8_size
  • bs_put_utf8
  • bs_utf16_size
  • bs_put_utf16
  • bs_put_utf32

These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

@pguyot pguyot force-pushed the w47/add-bs-utf-opcodes branch 4 times, most recently from af5dd4f to a70e09f Compare November 28, 2022 21:39
@pguyot pguyot marked this pull request as draft November 28, 2022 21:48
@pguyot pguyot force-pushed the w47/add-bs-utf-opcodes branch 2 times, most recently from 2ff484b to 69b16bb Compare December 1, 2022 07:40
@pguyot pguyot force-pushed the w47/add-bs-utf-opcodes branch 2 times, most recently from de3037b to 8454ff3 Compare December 20, 2022 06:26
@pguyot pguyot changed the base branch from master to feature/smp December 24, 2022 12:22
@pguyot pguyot changed the base branch from feature/smp to master December 24, 2022 12:22
@pguyot pguyot marked this pull request as ready for review December 24, 2022 12:23
This commit adds support for the following opcodes
- bs_utf8_size
- bs_put_utf8
- bs_utf16_size
- bs_put_utf16
- bs_put_utf32

Signed-off-by: Paul Guyot <pguyot@kallisys.net>
@pguyot pguyot force-pushed the w47/add-bs-utf-opcodes branch from 8454ff3 to 320d476 Compare January 1, 2023 08:54
@bettio bettio merged commit 084b739 into atomvm:master Jan 3, 2023
@pguyot pguyot deleted the w47/add-bs-utf-opcodes branch January 3, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants