ESP32/NVS: return namespace_not_found as undefined in get function
#755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bettio
changed the title
namespace_not_found as undefined in get function
namespace not found is quite common in a newly flash device, for consistency reasons it should be returned as undefined. Signed-off-by: Davide Bettio <davide@uninstall.it>
bettio
force-pushed
the
handle-ns-not-found
branch
from
b5ef080 to
ae78b3b
Compare
fadushin
approved these changes
Aug 13, 2023
Collaborator
fadushin
left a comment
fadushin
left a comment
There was a problem hiding this comment.
Seems legit. We should really have tests for this API in the esp tests (assuming NVS can be tested in QEMU)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
nvs_get_binary/2so it can work on devices with a completely erased NVS area.namespace not found is quite common in a newly flash device, for consistency reasons it should be returned as undefined.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later