Improve pico_flash task
#26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fadushin
reviewed
Feb 7, 2024
Collaborator
fadushin
left a comment
fadushin
left a comment
There was a problem hiding this comment.
Looks good. Just a few small comments.
At some point we need to use ports instead of os:cmd, but later!
UncleGrumpy
force-pushed
the
pico_flash_improved
branch
from
8115cba to
b512102
Compare
Collaborator
Author
I was just reading this a few hour ago! 🤣 |
fadushin
approved these changes
Feb 7, 2024
fadushin
reviewed
Feb 16, 2024
UncleGrumpy
force-pushed
the
pico_flash_improved
branch
6 times, most recently
from
eb9c959 to
4c8eb43
Compare
pguyot
reviewed
Feb 18, 2024
This set of changes will use `picotool` to reset the rp2040 device if a serial monitor is attached. A warning will also be issued notifying the user that faster flashing times can be achieved by disconnecting the serial monitor application before using the `atomvm pico_flash` task, as this also requires an extra delay before it can be put back into `BOOTSEL` mode. Signed-off-by: Winford <winford@object.stream>
UncleGrumpy
force-pushed
the
pico_flash_improved
branch
from
4c8eb43 to
43f3bc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of changes will use
picotoolto reset the rp2040 device if a serial monitor is attached. A warning will also be issued notifying the user that faster flashing times can be achieved by disconnecting the serial monitor application before using theatomvm pico_flashtask, as this also requires an extra delay before it can be put back intoBOOTSELmode.