forked from RDFLib/rdflib
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEMO: pre-commit and pre-commit-ci #35
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
aucampia
commented
Jan 22, 2022
•
edited
edited
Add bindings for rdflib namespaces. Import DCAM.
Hextuples Serializer
…hen performing de-skolemization.
demo 980 resolution
Fix BNode.skolemize() returning a URIRef instead of an RDFLibGenid.
…tement Remove deprecated Statement class
RDFLib#893, courtesy of Iddan Aaronsohn
which, depite the Github record [1] _didn't_ actually make it into master. [1] RDFLib@a7863d2
Re-make of nicholascar's “Concise Bounded Description” PR RDFLib#968 ...
Fix for issue 893
Fix for issue893
Raise a more specific Exception when lang isn't valid
Add IdentifiedNode abstract intermediary class
…space_typing Add typing to rdflib.namespace
The diagram is based on the diagram created by Graham Higgins (@gjhiggins) in RDFLib#1526 This shows the class heirarchy of various terms such as Identifier, IdentifiedNode, URIRef, Literal, etc. The diagram is in [plantuml](https://plantuml.com/class-diagram) and compiled to svg by the [kroki extension for sphinx](https://github.com/sphinx-contrib/kroki). Diagrams can be rendered from the plantuml at https://kroki.io/. Other changes: - Some updates to the "Writing RDFLib Documentation" page.
…_class_diag Add a class diagram for terms.
This adds as much typing as possible to `rdflib.term`. Other changes: - Added back `warn_unused_ignores`. I actually thought this was enabled but I forgot I disabled it because of some issue on python 3.10. - Disabled `warn_unused_ignores` only for `rdflib.plugin`. There is an ignore in this module which is not needed on python 3.10, this is the most targetted way to avoid having that fail the type checking that I can think of for now. - Removed unused type ignores. This changeset includes no runtime changes.
pre-commit.ci autofix |
Previously if `rdf:type` occurred in subject or object of a triple then turtle would have not added a prefix for rdf as it considered `rdf:type` to be a keyword regardless of where in the triple it occurred. This changeset ensures that rdf:type is only considered a keyword if it occurs as the predicate of a triple.
$ black --config black.toml .
Co-authored-by: Iwan Aucamp <aucampia@gmail.com>
aucampia
force-pushed
the
iwana-20220116T1355-precommit_ci_demo
branch
from
January 24, 2022 22:18
68df183
to
2ac7771
Compare
Black does not read config from black.toml, and without this change the config has no effect and tools like pre-commit ci will not do what we want.
…k_config Rename black.toml to pyproject.toml
…_typing Merging pull request as it contains only type changes and has one review.
…ld_rdf_prefix Merging as fix is trivial and PR has one review.
Add pre-commit and pre-commit-ci with the following hooks: - black for formatting code. For more info see `docs/developers.rst`.
aucampia
force-pushed
the
iwana-20220116T1355-precommit_ci_demo
branch
from
January 30, 2022 13:07
2ac7771
to
b2e124d
Compare
pre-commit.ci autofix |
Can be added later with the rest of isort.
This is to work around this issue: psf/black#2493 Without doing this the pre-commit hook for black fails as it thinks it got the wrong version.
aucampia
force-pushed
the
iwana-20220116T1355-precommit_ci_demo
branch
from
January 30, 2022 14:53
56710e9
to
3700b6c
Compare
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.