Remove unused variables #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebornix
reviewed
Jun 20, 2018
| router.get('/', function (req, res, next) { | ||
| var productId = products && products[0].id; | ||
|
|
||
| router.get('/', function (_req, res, _next) { |
rebornix
reviewed
Jun 28, 2018
| }); | ||
|
|
||
| router.get('/add/:id', function(req, res, next) { | ||
| router.get('/add/:id', function(req, res, _next) { |
rebornix
reviewed
Jun 28, 2018
| }); | ||
|
|
||
| router.get('/cart', function(req, res, next) { | ||
| router.get('/cart', function(req, res, _next) { |
|
I'll do a pass over the rest of the files as well |
|
Everything else looks pretty good |
|
beep beep |
RMacfarlane
commented
Aug 23, 2018
| title: 'NodeJS Shopping Cart', | ||
| products: products | ||
| } | ||
| ); |
This reverts commit fec0b5d.
added 2 commits
August 28, 2018 17:16
This reverts commit 83f75d0.
rebornix
reviewed
Oct 9, 2018
| .dropdown-menu .cart { | ||
| min-width: 250px; | ||
| padding: 15px 25px 0; | ||
| margin: 0; |
miguelsolorio
approved these changes
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused variables in index.js, prefix unused params with '_'