Fixed exception in Scala file parsing:#865
Merged
aure merged 1 commit intoAudioKit:developfrom Apr 28, 2017
marcus-w-hobbs:aktuningtable_proposal
Merged
Fixed exception in Scala file parsing:#865aure merged 1 commit intoAudioKit:developfrom marcus-w-hobbs:aktuningtable_proposal
aure merged 1 commit intoAudioKit:developfrom
marcus-w-hobbs:aktuningtable_proposal
Conversation
AKPolyphonicNode.tuningTable.numberField(fromScalaString:"! ptolemy.scl\n!\nPtolemy Intense Syntonon\n 7\n!\n 9/8\n 5/4\n 4/3\n 3/2\n 5/3\n 15/8\n 2/1\n") // now correctly parses numberField: [1.0, 1.125, 1.25, 1.3333333333333333, 1.5, 1.6666666666666667, 1.875]
houndci-bot
reviewed
Apr 28, 2017
| } | ||
|
|
||
| fileprivate func numberField(fromScalaString rawStr: String?) -> [Element]? { | ||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
|
|
||
| fileprivate func numberField(fromScalaString rawStr: String?) -> [Element]? { | ||
|
|
||
|
|
There was a problem hiding this comment.
Vertical Whitespace Violation: Limit vertical whitespace to a single empty line. Currently 3. (vertical_whitespace)
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
| fileprivate func numberField(fromScalaString rawStr: String?) -> [Element]? { | ||
|
|
||
|
|
||
| open func numberField(fromScalaString rawStr: String?) -> [Element]? { |
There was a problem hiding this comment.
Cyclomatic Complexity Violation: Function should have complexity 10 or less: currently complexity equals 22 (cyclomatic_complexity)
Function Body Length Violation: Function body should span 100 lines or less excluding comments and whitespace: currently spans 105 lines (function_body_length)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bug reported by Allan Hoeltje:
AKPolyphonicNode.tuningTable.numberField(fromScalaString:"! ptolemy.scl\n!\nPtolemy Intense Syntonon\n 7\n!\n 9/8\n 5/4\n 4/3\n 3/2\n 5/3\n 15/8\n 2/1\n")
// now correctly parses numberField: [1.0, 1.125, 1.25, 1.3333333333333333, 1.5, 1.6666666666666667, 1.875]