fix(virtual-repeat): make initially hidden elements display correctly #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.itemHeight = calcOuterHeight(firstViewElement); | ||
| if (this.itemHeight <= 0) { | ||
| throw new Error('Could not calculate item height'); | ||
| this._sizeInterval = setInterval(()=>{ |
Contributor
There was a problem hiding this comment.
this._sizeInterval might need to be terminated in the detached callback as well. In case the item height never gets greater than 0.
Contributor
Author
There was a problem hiding this comment.
Ohh, good call. Do you think 500ms is fine for the interval? I just made it match the interval (time wise) with the one defined earlier in regards to scrolling. Possibly make it faster, slower?
AStoker
force-pushed
the
view-change-problems
branch
from
887ad88 to
319cc59
Compare
fixes: aurelia#73 Previous behavior was that any `virtual-repeat` that was initially hidden could not correctly calculate heights. New behavior is such that initially hidden elements can display correctly after they have been shown.
Contributor
Author
|
Any other notes @martingust? |
Contributor
|
@AStoker I think it's all good. I'll get this merged later today. |
Contributor
Author
|
@martingust, any idea on when this will get published to a new release? |
Contributor
|
@EisenbergEffect Can you release this repo? There is a breaking change waiting in master b7ff555 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #73
Previous behavior was that any
virtual-repeatthat was initiallyhidden could not correctly calculate heights. New behavior is such that
initially hidden elements can display correctly after they have been
shown.