fix: cache still expires by default

TimeRaider · TimeRaider · commit 1cc07c5c8fc3 · 2016-11-10T17:07:32.000+05:00
use serialize-friendly Number.MAX_SAFE_INTEGER instead of Infinity
diff --git a/src/factory.js b/src/factory.js
@@ -42,7 +42,7 @@ export default function factory(localforage) {
         return isValid ? await cacheBins[bin].getItem(key) : null; // localForage return null if item doesn't exist
     }
 
-    async function set(bin, key, data, expire = Infinity) {
+    async function set(bin, key, data, expire = Number.MAX_SAFE_INTEGER) {
         return await Promise.all([
             cacheBins[EXPIRE_BIN].setItem(getExpireKey(bin, key), Date.now() + Number(expire)),
             cacheBins[bin].setItem(key, data)

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ export default function factory(localforage) {`
`42`	`42`	`return isValid ? await cacheBins[bin].getItem(key) : null; // localForage return null if item doesn't exist`
`43`	`43`	`}`
`44`	`44`
`45`		`- async function set(bin, key, data, expire = Infinity) {`
	`45`	`+ async function set(bin, key, data, expire = Number.MAX_SAFE_INTEGER) {`
`46`	`46`	`return await Promise.all([`
`47`	`47`	`cacheBins[EXPIRE_BIN].setItem(getExpireKey(bin, key), Date.now() + Number(expire)),`
`48`	`48`	`cacheBins[bin].setItem(key, data)`