refactor: Improve efficiency and reliability of fetching enabled_clients for connections #1334
Merged
kushalshit27 merged 4 commits intomasterfrom Mar 24, 2026
Merged
refactor: Improve efficiency and reliability of fetching enabled_clients for connections #1334kushalshit27 merged 4 commits intomasterfrom
enabled_clients for connections #1334kushalshit27 merged 4 commits intomasterfrom
Conversation
kushalshit27
changed the title
enabled_clients for connections enabled_clients for connections
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1334 +/- ##
==========================================
+ Coverage 80.16% 80.18% +0.01%
==========================================
Files 152 152
Lines 6096 6101 +5
Branches 1247 1247
==========================================
+ Hits 4887 4892 +5
Misses 693 693
Partials 516 516 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ankita10119
previously approved these changes
Mar 24, 2026
Contributor
ankita10119
left a comment
ankita10119
left a comment
There was a problem hiding this comment.
Approach looks good, worth adding a test to ensure pool based concurrency is used, so future refactors don't regress this behaviour undetected
…nnection order - test/tools/auth0/handlers/connections.tests.js: implement test to validate pool usage for enabled clients
kushalshit27
force-pushed
the
DXCDT-1471-rate-limit
branch
from
93d3c0b to
3b73c5a
Compare
Merged
ankita10119
added a commit
that referenced
this pull request
Apr 23, 2026
…gs (#1369) * refactor: Improve efficiency and reliability of fetching for (#1334) * refactor: Getting enabled clients for connection * feat(test): add test for fetching enabled clients while preserving connection order - test/tools/auth0/handlers/connections.tests.js: implement test to validate pool usage for enabled clients * feat(clients.ts): add external client fields and registration logic feat(clients.tests.js): implement tests for CIMD client creation and updates - src/tools/auth0/handlers/clients.ts: added external_client_id, external_metadata_type, external_metadata_created_by, jwks_uri fields - src/tools/auth0/handlers/clients.ts: implemented createClient and updateClient methods for CIMD clients - test/tools/auth0/handlers/clients.tests.js: added tests for creating and updating CIMD clients - test/tools/auth0/handlers/clients.tests.js: added validation test for external_metadata_type without external_client_id * feat(clients.ts): update editable fields for CIMD clients - src/tools/auth0/handlers/clients.ts: replace omit with pick to specify editable fields - src/tools/auth0/handlers/clients.ts: add new editable fields for CIMD clients * fix(package.json): update auth0 dependency version to ^5.7.0 * feat(src/tools/auth0/handlers/clients.ts): add calcChanges method for client change calculations feat(src/tools/auth0/handlers/clients.ts): update identifiers for client handling * fix(clients): remove unreachable guards in createClient and updateClient * fix(clients): add non-null assertion for external_client_id after isCimdClient guard * docs(examples): add CIMD client example to directory and yaml formats --------- Co-authored-by: Ankita Tripathi <51994119+ankita10119@users.noreply.github.com> Co-authored-by: ankitatripathi.mp@gmail.com <ankitatripathi.mp@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Improves the efficiency and reliability of fetching enabled clients for Auth0 connections by switching from a parallel
Promise.allapproach to a controlled concurrency pool, and includes some minor code cleanups and test adjustments. The main benefit is improved resource usage and more predictable execution, especially when dealing with many connections.📚 References
enabled_clientsfor connection with enhance client management #1294🔬 Testing
📝 Checklist