-
Notifications
You must be signed in to change notification settings - Fork 183
Closed
Labels
closed:staleIssue or PR has not seen activity recentlyIssue or PR has not seen activity recently
Description
Description
It would be quite useful for this library to support Python with type hints.
An obvious benefit is that users of the library, if using mypy or similar, are able to verify that they are using library in correct way, avoiding situations like:
- typos
- input data mismatch
- output data mismatch
There are 2 ways to do that:
- resolving Dropping support for old Pythons #207 first and baking annotations directly into codebase as a preferable method mentioned here
- getting an 👍 from this library maintainers and pushing
stubsinto python/typeshed library
Either works for me. I acknowledge that first option requires a lot of thinking and preparation whilst 2nd one is simply easier for auth0-python to keep compatibility with older Python versions for a little longer. I am willing to help with either #207 or this issue (either here or in typeshed)
Prerequisites
- I have checked the README documentation.
- I have checked the Auth0 Community for related posts.
- I have checked for related or duplicate Issues and PRs.
- I have read the Auth0 general contribution guidelines.
- I have read the Auth0 Code of Conduct.
- I am reporting this to the correct repository.
Environment
auth0-python==3.9.1- other factors does not seem to be relevant
Reproduction
I believe that an example like so is enough:
class TypingShowsAny:
def __init__(domain: str, access_token: str) -> None:
self._client = client = auth0.v3.management.Clients(domain, access_token)
reveal_type(client) reveal_type reports Any whilst it should report auth0.v3.management.Clients
mattbriancon, Sytten, jlucas91, authereal, aphilas and 3 more
Metadata
Metadata
Assignees
Labels
closed:staleIssue or PR has not seen activity recentlyIssue or PR has not seen activity recently