-
Notifications
You must be signed in to change notification settings - Fork 0
[DO NOT MERGE]feat: FGI-1573 add connected account support #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…/auth0-server-python into FGI-1573_connected-account-support
|
Claude finished @arpit-jn's task —— View job Overall Assessment❌ This PR is not ready to merge. Multiple security issues, logic bugs, and code quality problems must be addressed first. Critical Issues Requiring FixesSecurity Vulnerabilities:
Logic Bugs:
Code Quality Issues:
Recommendations
The feature implementation follows good patterns (PKCE, state management, transaction storage), but needs these issues resolved before merge. |
…ith one matching the audience Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…/auth0-server-python into FGI-1573_connected-account-support
|
Quick smoke test using https://github.com/jtemporal/minimal-fastapi-webapp-auth0 Seems to work ok
Couldn't test with DPoP because auth0-fastapi doesn't appear to support that |
|
@adamjmcgrath - DPoP is out of scope for this PR. My account supports DPoP but does not strictly require it (at least for now). DPoP support will be added in a future PR but given this SDK is for confidential (server-based) clients - it does not really add any additional security. |
Co-authored-by: Adam Mcgrath <adamjmcgrath@gmail.com>
Co-authored-by: Adam Mcgrath <adamjmcgrath@gmail.com>
Co-authored-by: Adam Mcgrath <adamjmcgrath@gmail.com>

Changes
Requires MRRT functionality in #58 to work
This change adds support for the new Connected Accounts flow.
start_connect_accountthat calls MyAccountAPI to initiate the flow. This returns a url with a ticket that a user should be redirected to to authenticate with the 3rd Party IdPcomplete_connect_accountwhich completes the flow following being redirected back from the 3rd Party IdPReferences
https://auth0team.atlassian.net/browse/FGI-1573
Testing
Manual testing can be done for this flow as described in the example doc in the PR. This flow does rely on transaction/state storage so requires an implementation of those stores. Since this library is typically intended to be used as a library to build framework specific implementations, it is probably most easily tested via this accompanying PR that implements framework support for this feature in FastAPI.
Pre-requisites
My Account API must be enabled on your Auth0 tenant
Connected Accounts must be enabled on your Auth0 tenant
MRRT must be configured for the tenant
This change adds unit test coverage
This change adds integration test coverage
This change has been tested on the latest version of the platform/language or why not
Checklist