This repository was archived by the owner on Apr 3, 2019. It is now read-only.
Fix parsing numbers #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move byte, decimal and double below int32 to prefer the int32 fo numbers; this makes the whole decimal numbers and byte and sbyte numbers unreachable rules, I am afraid Join the array of digits into a string before parsing an integer number from it
Move decimal, double and single before integer otherwise integer would be preferred and the decimal point would be handled as a dot for the next token; byte and sbyte are still unreachable, I am afraid Parse the decimal number into a string according to the OData specification
… single one Move decimal below double otherwise decimal would be preferred and the 'e' before the exponent would be considered for the next token Parse the double into a string according to the OData specification
Move boolean below sbyte to let integer-like tokens parsed earlier, otherwise the staring 1 would be caught by the boolean and the other digits would be handled as another token
Member
|
Very well done! Thank you very much and sorry for the long delay |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to fix #5
Convert arrays of digits to strings before parsing a number from them
Change the parsing order to double -> decimal -> integer to capture the longest tokens first
Parse decimals and doubles into strings according to the OData specification for the primitive types