feat: allow unsigned assertions#104
Merged
luuuis merged 6 commits intoauth0:masterfrom Sep 15, 2020
luuuis:allow-unsigned-assertions
Merged
feat: allow unsigned assertions#104luuuis merged 6 commits intoauth0:masterfrom luuuis:allow-unsigned-assertions
luuuis merged 6 commits intoauth0:masterfrom
luuuis:allow-unsigned-assertions
Conversation
…nAssertion: false` is passed in
…on` as this may now be unsigned
CriGoT
suggested changes
Sep 15, 2020
Contributor
CriGoT
left a comment
CriGoT
left a comment
There was a problem hiding this comment.
Can we add the options to the README.md?
CriGoT
approved these changes
Sep 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows unsigned assertions using the
options.signAssertionconfig property. This is an optional property that defaults to true.Testing
Unit tests added for all relevant combinations.