fix: support signed logout response sent via POST#140
Merged
ArtiomCiumac merged 2 commits intomasterfrom Nov 17, 2023
Merged
Conversation
jakelacey2012
approved these changes
Nov 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
This fixes checking for signed LogoutResponse during SLO scenarios when the app posts the response via POST. In such situation the code was still trying to load the signature from query and was failing to do so.
Testing
Set up SAML SLO with 2 applications:
Expected results after this PR:
The SLO should complete and it should be visible in browser dev tools that the app sends signed responses across all SAML requests.
Actual results before this PR:
The second session participant app LogoutResults fails the verification on the IDP side (this lib).
Checklist