Skip to content

Conversation

@Apostrophii
Copy link

No description provided.

@coveralls
Copy link

coveralls commented May 1, 2018

Coverage Status

Coverage decreased (-0.05%) to 85.317% when pulling 9699c0d on Apostrophii:remove-duplicate-tests into f15f9a9 on autoNumeric:next.

it('should accepts Arabic numbers', () => {
expect(aNInput.getNumericString()).toEqual('');
aNInput.set('١٠٢٣٤٥٦٧.٨٩');
aNInput.set('۱٠۲۳۴۵۶۷.۸۹');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't you changing the Arabic numbers to the Persian ones here?

@AlexandreBonneau AlexandreBonneau self-assigned this May 1, 2018
@AlexandreBonneau
Copy link
Member

Thanks for the pull request @Apostrophii and pointing out inconsistencies in the unit tests with those three repeated test blocks.
It seems when I added support for the Arabic numbers I forgot to complete the tests I was supposed to write.

So instead of just removing those, I've modified and added the tests I should I wrote in the first place.

Thank you again for your contribution and taking the time to look at the AutoNumeric source.

I'll close this PR since most of the changes will be overwritten by the next commit, however about the change of the Arabic numbers to Persian ones, if you feel I missed something here, do not hesitate to reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants