Skip to content

added _RequestError to handle HTTP errors #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 31, 2017
Merged

added _RequestError to handle HTTP errors #52

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
743b60f
added _RequestError to handle HTTP errors
1u0n Jul 8, 2017
a3d96d6
Merge pull request #1 from 1u0n/1u0n-patch-RequestError
1u0n Jul 8, 2017
a5235ea
Update autocomplete.ts
1u0n Jul 12, 2017
71ed2e0
Merge pull request #2 from 1u0n/1u0n-patch-RequestTimeout
1u0n Jul 12, 2017
ade2c94
Update autocomplete.ts
1u0n Jul 12, 2017
0ffae01
travis test doesn't allow functions with 4 parameters. Reverting to a…
1u0n Jul 12, 2017
4f04fc0
renamed _RequestError to _Error
1u0n Aug 31, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions src/autocomplete.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ interface Params {
_RenderResponseItems: any;
_Select: any;
_Url: any;
_Error: any;

// Internal item
$AjaxTimer: number;
Expand Down Expand Up @@ -222,7 +223,8 @@ class AutoComplete {
function(response: string) {
this._Render(this._Post(response));
this._Open();
}.bind(this)
}.bind(this),
this._Error
);
}
},
Expand Down Expand Up @@ -494,6 +496,11 @@ class AutoComplete {
}
this.Input.setAttribute("data-autocomplete-old-value", this.Input.value);
},
/**
* Handle HTTP error on the request
*/
_Error: function(): void {
},

$AjaxTimer: null,
$Cache: {},
Expand Down Expand Up @@ -601,7 +608,7 @@ class AutoComplete {
}
}

makeRequest(params: Params, callback: any): XMLHttpRequest {
makeRequest(params: Params, callback: any, callbackErr: any): XMLHttpRequest {
var propertyHttpHeaders: string[] = Object.getOwnPropertyNames(params.HttpHeaders),
request: XMLHttpRequest = new XMLHttpRequest(),
method: string = params._HttpMethod(),
Expand All @@ -628,6 +635,9 @@ class AutoComplete {
params.$Cache[queryParams] = request.response;
callback(request.response);
}
else if (request.status >= 400) {
callbackErr();
}
};

return request;
Expand All @@ -650,11 +660,11 @@ class AutoComplete {
}
}

cache(params: Params, callback: any): void {
cache(params: Params, callback: any, callbackErr: any): void {
var response: string|undefined = params._Cache(params._Pre());

if (response === undefined) {
var request: XMLHttpRequest = AutoComplete.prototype.makeRequest(params, callback);
var request: XMLHttpRequest = AutoComplete.prototype.makeRequest(params, callback, callbackErr);

AutoComplete.prototype.ajax(params, request);
} else {
Expand Down