Skip to content

Conversation

@Elliria
Copy link
Member

@Elliria Elliria commented Jan 27, 2025

This one has three commits instead of two because I messed up the syntax of the CHANGELOG.md entry and fixed it in a new commit.

Copy link
Member

@troxor troxor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After squash+merge, all the commits will become one anyway so no big deal!

@Elliria
Copy link
Member Author

Elliria commented Jan 27, 2025

Yep. I figured I'd mention it, though, since the diff only shows two changes when there were three commits.

@Elliria Elliria merged commit a1922c3 into autokey:master Feb 1, 2025
@Elliria
Copy link
Member Author

Elliria commented Feb 1, 2025

The failed workflow run happened because it was still using the old action versions, which have been updated now. All is well.

@josephj11
Copy link
Contributor

I have no idea what I'm looking at, but just in case:
https://github.com/autokey/autokey.github.io/actions/runs/13090295269/workflow
lines 35 and 49 both use a version 1 action.
Does that have anything to do with it?

@Elliria
Copy link
Member Author

Elliria commented Feb 2, 2025

You're doing great. Line 35 was the problem, because upload-pages-artifact version 1 relied on a deprecated version of the upload-artifact package. This was solved by the update to the actions that was done yesterday, so it shouldn't be a problem going forward.

@Elliria Elliria deleted the update_the_dependencies branch February 11, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants