Fix fit, refit, fit_ensemble not returning self + Unit tests #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 3, 2018 18:10
Codecov Report
@@ Coverage Diff @@
## development #476 +/- ##
==============================================
+ Coverage 78.59% 78.6% +0.01%
==============================================
Files 130 130
Lines 10088 10093 +5
==============================================
+ Hits 7929 7934 +5
Misses 2159 2159
Continue to review full report at Codecov.
|
ahn1340
changed the title
mfeurer
requested changes
May 15, 2018
Contributor
mfeurer
left a comment
mfeurer
left a comment
There was a problem hiding this comment.
Also, I'm not sure if this was ready for review. Please remove the WIP tag once this is ready for review.
test/test_automl/test_estimators.py
Outdated
| class AutoSklearnClassifierTest(unittest.TestCase): | ||
| # Currentl this class only tests that the methods of AutoSklearnClassifier | ||
| # which should return self actually return self. | ||
| def test_classification_fit_returns_self(self): |
Contributor
There was a problem hiding this comment.
Could you please merge all of these tests into one?
test/test_automl/test_estimators.py
Outdated
| class AutoSklearnRegressorTest(unittest.TestCase): | ||
| # Currently this class only tests that the methods of AutoSklearnRegressor | ||
| # that should return self actually return self. | ||
| def test_regression_fit_returns_self(self): |
Contributor
There was a problem hiding this comment.
Could you please also merge all of the regression tests into one?
Contributor
Author
|
All unittests are now merged into one (for classification and regression respectively). |
mfeurer
approved these changes
May 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.