Skip to content

Conversation

@ahn1340
Copy link
Contributor

@ahn1340 ahn1340 commented May 12, 2019

Introduces new way of computing training loss for cross-validation.

@ahn1340 ahn1340 changed the title Runtime warning [WIP]Runtime warning May 16, 2019
@ahn1340 ahn1340 changed the title [WIP]Runtime warning Runtime warning Aug 27, 2019
@ahn1340 ahn1340 requested a review from mfeurer August 27, 2019 11:14
@ahn1340
Copy link
Contributor Author

ahn1340 commented Aug 27, 2019

@mfeurer, sorry for the really late notice. The PR is done but Travis still fails due to the xgboost errors. Other than that, I believe the code works fine. Please have a look at it and let me know.

@mfeurer
Copy link
Contributor

mfeurer commented Aug 30, 2019

This looks good, thanks a lot @ahn1340.

Sorry that it took me so long to check this, too.

@mfeurer mfeurer changed the base branch from master to development August 30, 2019 09:15
@mfeurer mfeurer merged commit 0c99895 into automl:development Aug 30, 2019
franchuterivera pushed a commit to franchuterivera/auto-sklearn that referenced this pull request Aug 21, 2020
* First Commit. Change way of computing train loss.

* Minor fix

* Minor fix again

* Update computing train loss

* Modify finish_up()

* Fix unittest errors, modify train_loss computation to account for dicts

* Fix unittest errors

* Modify the way optimization loss is computed in train_evaluator.py

* Modify errors

* Fix Unittest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants