-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add SelectRates for regression [fix: #375] #690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ba3562c to
de43a60
Compare
franchuterivera
added a commit
to franchuterivera/auto-sklearn
that referenced
this pull request
Aug 21, 2020
b4bb9e1 to
ecb5678
Compare
mfeurer
reviewed
Aug 26, 2020
autosklearn/pipeline/components/feature_preprocessing/select_rates_classification.py
Outdated
Show resolved
Hide resolved
autosklearn/pipeline/components/feature_preprocessing/select_rates_classification.py
Outdated
Show resolved
Hide resolved
autosklearn/pipeline/components/feature_preprocessing/select_rates_classification.py
Outdated
Show resolved
Hide resolved
autosklearn/pipeline/components/feature_preprocessing/select_rates_regression.py
Outdated
Show resolved
Hide resolved
autosklearn/pipeline/components/feature_preprocessing/select_rates_regression.py
Outdated
Show resolved
Hide resolved
autosklearn/pipeline/components/feature_preprocessing/select_rates_regression.py
Outdated
Show resolved
Hide resolved
test/test_pipeline/components/feature_preprocessing/test_select_rates_regression.py
Outdated
Show resolved
Hide resolved
mfeurer
reviewed
Aug 28, 2020
Contributor
mfeurer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New changes look great, but please see my comment regarding the pcs file.
Contributor
|
Closes #375 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added support for regression in SelectRates similar to
autosklearn.pipeline.components.feature_preprocessing.select_percentile_regression