Skip to content

Conversation

@nazar-pc
Copy link
Member

In test run the process was killed, I guessed it is because our codebase gets heavier over time, so compiling took more RAM. Separating farmer and node into separate steps helped CI to pass successfully.

Code contributor checklist:

  • I have reviewed my own changes one more time to spot typos, unintended changes, following project conventions, etc.
  • I have prepared clean readable history of commits before submitting this PR to make reviewer's life easier
  • I have tested my changes and/or added corresponding test cases (if relevant)
  • I understand that any changes to this PR going forward will notify multiple developers and will try to minimize them
  • I have added sufficient description of changes to make review process easier
  • This PR is ready for review by developers

@nazar-pc nazar-pc requested a review from rg3l3dr as a code owner July 23, 2022 21:54
@nazar-pc nazar-pc enabled auto-merge July 23, 2022 21:55
@nazar-pc nazar-pc merged commit 06ec9a6 into main Jul 24, 2022
@nazar-pc nazar-pc deleted the build-node-farmer-separately branch July 24, 2022 10:00
@nazar-pc
Copy link
Member Author

Hm... another job got killed here: https://github.com/subspace/subspace/runs/7490192102?check_suite_focus=true

Not sure why, test run in my repo worked just fine 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants