Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): replace lost count to lost time #1142

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

The PR aims to replace integer count to time-based.

Signed-off-by: Muhammad Zulfaqar Azmi zulfaqar.azmi@tier4.jp

Description

Previous perception lost is handle by counting integer value lost_count parameter from the ObjectData. However, it might be suitable to use time-based as the metric. This PR aims to replace lost_count with last_seen.

Note behavior changes should be observed.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #1142 (528ab27) into main (47e517a) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main   #1142      +/-   ##
========================================
- Coverage   9.60%   9.48%   -0.12%     
========================================
  Files       1072    1074       +2     
  Lines      73923   74856     +933     
  Branches   16256   16950     +694     
========================================
+ Hits        7098    7099       +1     
- Misses     60278   61067     +789     
- Partials    6547    6690     +143     
Flag Coverage Δ *Carryforward flag
differential 0.89% <0.00%> (?)
total 9.58% <0.00%> (ø) Carriedforward from 47e517a

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
.../include/behavior_path_planner/debug_utilities.hpp 0.00% <0.00%> (ø)
...r/scene_module/avoidance/avoidance_module_data.hpp 0.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 0.35% <0.00%> (+0.11%) ⬆️
...ning/behavior_path_planner/src/debug_utilities.cpp 0.00% <0.00%> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <0.00%> (ø)
..._path_planner/src/scene_module/avoidance/debug.cpp 0.00% <0.00%> (ø)
...e/obstacle_avoidance_planner/eb_path_optimizer.hpp 0.00% <ø> (ø)
...anner/include/obstacle_avoidance_planner/utils.hpp 0.00% <ø> (ø)
...stacle_avoidance_planner/src/eb_path_optimizer.cpp 0.00% <0.00%> (ø)
...g/obstacle_avoidance_planner/src/mpt_optimizer.cpp 0.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd46fd2...528ab27. Read the comment docs.

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 force-pushed the feat/lost-object-hold-using-time-instead-of-count branch from e3b1383 to 7f923f3 Compare June 21, 2022 14:29
yukkysaito added a commit to yukkysaito/autoware.universe that referenced this pull request Jun 29, 2022
* Feature/awapi awiv adapter first pr (autowarefoundation#685)

* add base file of awapi_awiv_adapter

* publish autoware status

* update readme

* fix readme

* rename file

* add relay topic

* change msg name

* publish autoware status

* update readme

* add new message

* add lane change topic, obstacle avoidance topic

* update readme

* fix readme

* add namespace

* rename lane change available

* fix readme

* change pub hz

* change topic name

* change control mode and add gate_mode

* fix readme

* update readme

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix typo (autowarefoundation#687)

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* move msg file to autoware_api_msgs (autowarefoundation#693)

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Fix/awapi awiv adapter (autowarefoundation#698)

* subscribe global rpt

* update readme

* update readme

* add warning

* fix readme

* update readme

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* add check mark for awapi readme (autowarefoundation#723)

* add check mark for awapi readme

* add blank

* add blank

* add blank

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Feature/stop reason api (autowarefoundation#729)

* fix indent of readme

* add mock of stop reason aggregator

* add constptr to stop reason

* aggregate message

* add empty handling

* add nullptr handling

* fix bug

* update readme

* fix bug

* remove unused ifdef

* unify same reason msg to stop factor

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* modify put/goal -> put/route (autowarefoundation#736)

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Feature/add goal api (autowarefoundation#734)

* add  goal api

* add msg

* update readme

* add  const auto

* clean code

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Feature/extract leaf diag info (autowarefoundation#741)

* add mock function of extract leaf diag

* remove parent diag

* change method of isLeaf

* clean code

* change varibale/function name

* remove string predefine

* update readme

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* update awapi readme (autowarefoundation#747)

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Feature/change output awapi (autowarefoundation#782)

* change ouput of awapi

* change error output to warn

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Feature/add battery to awapi (autowarefoundation#804)

* implement battery fuel

* update readme

* add getGearInfo

* fix message name

* set default value:nan to battery

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* remove ROS1 packages temporarily

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Revert "remove ROS1 packages temporarily"

This reverts commit c85c1d6789b1a1e63c6b4e60fa4f3296dfb12e74.

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* add COLCON_IGNORE to ros1 packages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Rename launch files to launch.xml (autowarefoundation#28)

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Port awapi_awiv_adapter to ROS2 (autowarefoundation#51)

* Port autoware_api_msgs to ROS2

* Integrate topic_tools

* Don't inherit from Node, convert to milliseconds

* Remove _node suffix from non-node loggers

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Rename h files to hpp (autowarefoundation#142)

* Change includes

* Rename files

* Adjustments to make things compile

* Other packages

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143)

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Use quotes for includes where appropriate (autowarefoundation#144)

* Use quotes for includes where appropriate

* Fix lint tests

* Make tests pass hopefully

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Run uncrustify on the entire Pilot.Auto codebase (autowarefoundation#151)

* Run uncrustify on the entire Pilot.Auto codebase

* Exclude open PRs

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Add linters (autowarefoundation#227)

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Ros2 v0.8.0 awapi awiv adapter (autowarefoundation#282)

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Ros2 v0.8.0 engage (autowarefoundation#342)

* [autoware_vehicle_msgs]: Add engage message

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [as]: Update message

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [awapi_awiv_adapter]: Update message

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [web_controller]: Update message

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [vehicle_cmd_gate]: Update message

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [autoware_state_monitor]: Update message

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [autoware_control_msgs]: Remove EngageMode message

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [simple_planning_simulator]: Update message

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Ros2 v0.8.0 remove std msgs awapi (autowarefoundation#348)

* [autoware_vehicle_msgs] add BatteryStatus msg

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* [autoware_planning_msgs] add ExpandStopRange and StopSpeedExceeded messages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* [autoware_api_msgs] add DoorControlCommand, StopCommand, and VelocityLimit messages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* remove std_msgs related to autoware_awaiv_adapter node

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* apply ament_uncrustify

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* fix build failure

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* fix test failures

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* address review commends

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Awapi update v0.9.0 (autowarefoundation#350)

* Feature/add current maxvel to awapi (autowarefoundation#1142)

* add current max vel to awapi

* add readme

* apply format

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* fix build error

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Add missing return (autowarefoundation#1170)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix cast type

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* [awapi_awiv_adapter] fix bug in the launch file (autowarefoundation#391)

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* modify pose_initialize for foa  (autowarefoundation#382)

* pose_initialize for foa (autowarefoundation#1171)

* pose_initialize for foa

Signed-off-by: Yamato ANDO <yamato.ando@gmail.com>

* rename topic

Signed-off-by: Yamato ANDO <yamato.ando@gmail.com>

* fix topic name

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix topic name (autowarefoundation#404)

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* [awapi_awiv_adapter] fix qos for some of the topics in awapi_awiv_adapter (autowarefoundation#413)

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Fix transform (autowarefoundation#420)

* Replace rclcpp::Time(0) by tf2::TimePointZero() in lookupTransform

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix canTransform

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix test

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Fix typo in awapi module (autowarefoundation#438)

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Import v0.9.1 (autowarefoundation#431)

* add local optimal solution ocillation check to ndt_scan_matcher (autowarefoundation#1182)

* Add obstacle_crush diagnostic (autowarefoundation#1186)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix diagnostics api (autowarefoundation#1185)

* Fix diagnostics api

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Don't overwrite level

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Overwrite level of No Fault diagnostics

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add missing diag in autoware_error_monitor.yaml (autowarefoundation#1187)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Filter hazard_status (autowarefoundation#1191)

* Filter hazard_status

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Filter leaf diagnostics

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix wrong calculation of available memory. (autowarefoundation#1168)

* Fixed wrong calculation of available memory.

* Added comments about output example of free -tb command.

* Change monitoring method to get HDD temperature and usage per specified device. (autowarefoundation#1195)

* Changed monitoring method to get temperature and usage per specified device.

* Fixed test codes.

* Removed unnecessary (void) parameter.

* return input pointcloud when ground plane not found (autowarefoundation#1190)

* fix yaw-smoothing bug (autowarefoundation#1198)

* Fix lint

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>
Co-authored-by: ito-san <57388357+ito-san@users.noreply.github.com>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* add tl overwriter relay in awapi (autowarefoundation#451)

* add tl overwriter relay in awapi

* add missed topic type

* fix typo of topic name

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* add use_sim-time option (autowarefoundation#454)

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Format launch files (autowarefoundation#1219)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Fix rolling build errors (autowarefoundation#1225)

* Add missing include files

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Replace rclcpp::Duration

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Use reference for exceptions

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Use from_seconds

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Awapi relay component (autowarefoundation#1237)

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Refine BSD license name (autowarefoundation#1244)

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Remove use_sim_time for set_parameter (autowarefoundation#1260)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Clear hazard level when ignored (autowarefoundation#1200) (autowarefoundation#1289)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix flake8 (autowarefoundation#1306)

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Add perception traffic light state output (autowarefoundation#1302)

* Add perception traffic light state output

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Modify message type

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Apply message type to relay

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Fix lint errors (autowarefoundation#1378)

* Fix lint errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix variable names

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* change msg type looking traffic light state (autowarefoundation#1494)

* change msg type looking traffic light state (autowarefoundation#1455)

* change msg type looking traffic light state

* fix msg name

* using namespace

* change function name

* fix typo

* add readme

* Update awapi/awapi_awiv_adapter/Readme.md

fix typo

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

* Remove deprecated message include

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix lint

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Add markdownlint and prettier (autowarefoundation#1661)

* Add markdownlint and prettier

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore .param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Fix -Wunused-parameter (autowarefoundation#1836)

* Fix -Wunused-parameter

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix mistake

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix spell

* Fix lint issues

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore flake8 warnings

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Fix compiler warnings (autowarefoundation#1837)

* Fix -Wunused-private-field

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix -Wunused-variable

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix -Wformat-security

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix -Winvalid-constexpr

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix -Wdelete-non-abstract-non-virtual-dtor

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix -Wdelete-abstract-non-virtual-dtor

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix -Winconsistent-missing-override

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix -Wrange-loop-construct

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix "invalid application of 'sizeof' to an incomplete type"

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore -Wgnu-anonymous-struct and -Wnested-anon-types

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix lint

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore -Wno-deprecated-declarations in CUDA-related packages

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix mistake

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix -Wunused-parameter

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Add autoware api (autowarefoundation#1979)

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Feature/add virtual traffic light planner (autowarefoundation#1588)

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Move launch file of external_cmd_selector (autowarefoundation#2017)

* Move launch file of external_cmd_selector

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Add copyright

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Use DeclareLaunchArgument

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix external command api name

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Move common parameters

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix format

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix format

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Use EmergencyState instead of deprecated EmergencyMode (autowarefoundation#2030)

* Use EmergencyState instead of deprecated EmergencyMode

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Use stamped type

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* add sort-package-xml hook in pre-commit (autowarefoundation#1881)

* add sort xml hook in pre-commit

* change retval to exit_status

* rename

* add prettier plugin-xml

* use early return

* add license note

* add tier4 license

* restore prettier

* change license order

* move local hooks to public repo

* move prettier-xml to pre-commit-hooks-ros

* update version for bug-fix

* apply pre-commit

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix awapi_autoware_state_publisher (autowarefoundation#2085)

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Feature/porting behavior path planner (autowarefoundation#1645)

* Add behavior path planner pkg with Lane Change (autowarefoundation#1525)

* add lanelet extension funcs

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* add planning msgs for FOA

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* add behavior_path_planner pkg

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* apply clang format

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* add error handling for config load failure

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* replace word: foa with remote control

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* add readme

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* use pointer for return value of path

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix hz

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* remove debug print

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* remove shide-shift & avoidance related files

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Clip path by goal

* add build depend for behavior tree cpp

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* temporally disable lint test in lanelet2_extension

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

Co-authored-by: rej55 <rej55.g@gmail.com>

* Add avoidance module in behavior_path_planner (autowarefoundation#1528)

* Revert "remove shide-shift & avoidance related files"

This reverts commit d819ea0291fca251012e4b9ffd16de3896830aa2.

* refactor findNewShiftPoint func

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* remove duplicated decleration

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix barkward length issue
 - add clipPathLenght func in avoidance

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* refactor:
 - translate english
 - minor modification for traffic distance

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* support debug marker in behavior_path_planner

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* clean up side shift module

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* change topic name

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* remove japanese

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Update planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner/include/behavior_path_planner/scene_module/side_shift/side_shift_module.hpp

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

* fix typo

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* remove unused var

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* adress reviewer comments:
 - add const for variables
 - add comment
 - fix typo

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix typo

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

* Replace behavior_path utilities with autoware_utils (autowarefoundation#1532)

* replace calcDistance

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* replace arange

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* replave convertToEigenPt with autoware_utils::fromMsg

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* replace normalizeRadian

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* cosmetic change

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* import autowarefoundation#1526 into behavior path planner (autowarefoundation#1531)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Fix/behavior path empty path output guard (autowarefoundation#1536)

* add guard

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Update planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner/src/behavior_path_planner.cpp

* fix lateral jerk calculation (autowarefoundation#1549)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix: error handling on exception in behavior_path_planner (autowarefoundation#1551)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Fix ignore too steep avoidance path (autowarefoundation#1550)

* ignore too steep path

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Update planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp

* parametrize lateral jerk limit

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Update planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner/include/behavior_path_planner/scene_module/avoidance/avoidance_module.hpp

Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>

Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>

* use offsetNoThrow and add error log (autowarefoundation#1615)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Ignore object ahead goal for avoidance (autowarefoundation#1618)

* Ignore object ahead goal for avoidance

* Add flag

* Fix position of definition of goal_pose

* Fix arclength calculation

* Fix position of definition of goal_pose

* fix intersection stop line (autowarefoundation#1636)

* fix intersection stop line

* fix typo

* add document (autowarefoundation#1635)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Port behavior path planner to ros2

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Apply lint

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix typo

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix map qos

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* debug slope calculation in behavior (autowarefoundation#1566)

* update

* update

* revert change of autoware_utils

* define getPose in behavior_path_planner

* update

* update

* update

* update

* interpolate z in obstacle_avoidance_planner

* update velocity controller

* fix detection area and scene

* Update planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner/src/utilities.cpp

Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>

* update comment in velocity controller

* remove debug print

* update

Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>

* Address review: Fix config file name

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* pre-commit fixes

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix redeclaring parameters

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add missing tf2 geometry function

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Apply lint

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix rclcpp Time initialization

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Use now() instead of msg stamp

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Use throttle output in getExpandedLanelet

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add missing const

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix lint

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: rej55 <rej55.g@gmail.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Feature/porting motion velocity smoother (autowarefoundation#1653)

* Add motion_velocity_smoother (autowarefoundation#1333)

* Refactor node and utilities

* Fix utilities

* Fix utilities

* Fixing...

* Runs with L2 smoother

* Use boost::optional

* Add Linf, JerkFiltered

* JerkFiltered

* Fix

* Fix awapi

* Fix bug

* Add config files

* Fix bug

* Fix bug and apply clang-format

* Remove unused variable

* Fix bug

* Change C-style cast to static_cast

* Add destructors

* Use smart pointers for members

* Add test

* Fix test code

* Tmp: add L2 norm of jerk in objective function

* Fix external velocity limit

* Fix interpolate in velocity controller and remove prevent move to close stop line

* add initial velocity and acceleration to the filter function

* Fix index calculation

* add new marge function

* handle edge case

* Tmp: skip osqp_interface build test

* Revert get_modified_package.sh

* Fix CI

* Fix version of osqp

* Fix

* Add design docment (JPN)

* Fix linear interpolation

* Refactor node and utilities

* Fix utilities

* Fix utilities

* Fixing...

* Runs with L2 smoother

* Use boost::optional

* Add Linf, JerkFiltered

* JerkFiltered

* Fix

* Fix awapi

* Fix bug

* Add config files

* Fix bug

* Fix bug and apply clang-format

* Remove unused variable

* Fix bug

* Change C-style cast to static_cast

* Add destructors

* Use smart pointers for members

* Add test

* Fix test code

* Tmp: add L2 norm of jerk in objective function

* Fix external velocity limit

* Fix interpolate in velocity controller and remove prevent move to close stop line

* add initial velocity and acceleration to the filter function

* Fix index calculation

* add new marge function

* handle edge case

* Tmp: skip osqp_interface build test

* Revert get_modified_package.sh

* Fix CI

* Fix version of osqp

* Fix

* Add design docment (JPN)

* Fix linear interpolation

* add new sample function

* Fix

* Revert velocity_controller

* Reset motion_velocity_optimizer

* Fix parameter setting

* Refactor and fix bugs

* Use autoware_utils

* Fix doc and bug

* Fix doc

* Fix external velocity limit and parametrize margin and jerk weight

* Fix typo

* Fix typo and remove old readme

* add stop point calculation and modify objective function

* Add parameter handling functions and add namespace

* Rename calcClosestTrajectoryPoint to calcInterpolatedTrajectoryPoint and remove unused function

* Fix applyExternalVelocityLimit and fix comments

* Fix variable name

* Fix variable name

* Fix yaml comment

* Add const

* Fix interpolaion

* Remove run() and change type of prev_closest_point_

* Update planning/scenario_planning/common/motion_velocity_smoother/src/smoother/smoother_base.cpp

Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>

* fix stop point error

* Fix linear interpolation and external velocity calculation

* Remove debug code

* Rename BaseParam

* Remove unused func and fix misc

* Fix package.xml, include, apply formatting

* Fix external velocity limit

* add debug calculation time

* modify calculation time debugger

* modify calculation time publisher

* rescale the calculation time

* Fix some problem

* Update planning/scenario_planning/common/motion_velocity_smoother/launch/motion_velocity_smoother.launch

Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>

Co-authored-by: yutaka <purewater0901@gmail.com>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>

* Add Resample Procedure after the optimization in motion_velocity_smoother (autowarefoundation#1530)

* do resample after the optimization

* modify resample timing

* add 0 at the end of the resampeld output trajectory

* Manage parameters

* Fix format

* Fix format

* Devide resample function in other file

* Update default_motion_velocity_smoother.yaml

* Update default_motion_velocity_smoother.yaml

Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>

* Output debug trajectories in motion velocity smoother (autowarefoundation#1533)

* add debug trajectory

* add rqt_multiplot setting files

* add calculation tiem visualization

* guard emtpy output (autowarefoundation#1537)

* Motion velocity smoother doc (autowarefoundation#1563)

* Fix doc

* Add english doc (tmp)

* Add english file

* Remove unused files

* Fix

* Fix typo

* Modify 1-size trajectory handling & warning messages (autowarefoundation#1540)

* add new guard to delete unnecessary message

* change message

* add warning messages

* chnage message to warning

* chnage to throttle

* Fix jerk filter calculation (autowarefoundation#1593)

* modify jerk filter calculation

* remove unnecessary code

* change the way of interp. of pose in smoother (autowarefoundation#1600)

* Update smoother resampling (autowarefoundation#1595)

* add new guard to delete unnecessary message

* change message

* add warning messages

* chnage message to warning

* chnage to throttle

* modify jerk filter calculation

* modify jerk filter calculation

* separate resampling code

* add new parameter

* add new parameter to dynamic reconfigure

* remove unnecessary code

* add sampling before optimization

* add const and blocker

* change access to at

* fix terminal length value

* add comments

* clean code

* add comment

* Fix/insert backward on reverse trajectory (autowarefoundation#1602)

* remove unused code

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* move debug code

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix insert backward on reverse trajectory

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Porting motion velocity smoother to ros2

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix launch and fix warning

* pre-commit fixes

* Remove unused argument

* Comment out unused parameter

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add distance threshold in motion_velocity_smoother (autowarefoundation#1659)

* Add distance threshold

* Remove parameters and use default value

* Fix for pre-commit

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Support Non-zero Stop Point Acceleration (autowarefoundation#1651)

* Support non-zero stop point acceleration

* modify zero velocity id search function (autowarefoundation#1690)

* modify zero velocity id search function

* Fix resample function and error handling

* Add comment

Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>

* Apply lint

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* pre-commit fixes

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
Co-authored-by: yutaka <purewater0901@gmail.com>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: purewater0901 <43805014+purewater0901@users.noreply.github.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: pre-commit <pre-commit@example.com>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Fix/update max velocity topic name (autowarefoundation#2236)

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Change formatter to clang-format and black (autowarefoundation#2332)

* Revert "Temporarily comment out pre-commit hooks"

This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3.

* Replace ament_lint_common with autoware_lint_common

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove ament_cmake_uncrustify and ament_clang_format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply Black

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix for cpplint

* Fix include double quotes to angle brackets

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Add COLCON_IGNORE (autowarefoundation#500)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Port awapi awiv adapter to .auto (autowarefoundation#554)

* Remove COLCON_IGNORE

* Change AutowareState

* Change EmergencyState

* Change HazardStatus

* Split file for convert function

* Change Path

* Change Trajectory

* Change ControlMode

* Change Shift

* Change TurnSignal and move converter

* Change Steering

* Change VehicleCommand

* Fix EmergencyState

* Fix for pre-commit

* Move autoware state converter

* Fix control comand

* Change TwistStamped

* Remove unused header

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Use pacmod3 msgs (autowarefoundation#610)

* Migration to pacmod3 msgs

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix action for pacmod

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Run pre-commit

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix package.xml (autowarefoundation#630)

Co-authored-by: Takayuki Murooka <takayuki.murooka@tier4.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* adapt to actuation cmd/status as control msg (autowarefoundation#646)

* adapt to actuation cmd/status as control msg

* fix readme

* fix topics

* fix remaing topics

* as to pacmod interface

* fix vehicle status

* add header to twist

* revert gyro_odometer_change

* revert twist topic change

* revert unchanged package

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix awapi topics (autowarefoundation#685)

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix mixed route topic (autowarefoundation#695)

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Fix/psim topics emergency handler awapi (autowarefoundation#702)

* fix emergency handler

* fix awapi

* remove unused topic

* remove duplecated vehicle cmd

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Fix topic type of awapi relay (autowarefoundation#701)

* Fix topic type of awapi relay

* Fix

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix door cmd topic (autowarefoundation#711)

* fix door cmd topic

* fix topic

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Update traffic light topic name (autowarefoundation#729)

* Update traffic light topic name

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Update traffic light topic name in perception

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* Update twist topic name (autowarefoundation#736)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix: refactor readme

Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>

Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: hiroyuki obinata <58019445+obi-t4@users.noreply.github.com>
Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Co-authored-by: Nikolai Morin <nnmmgit@gmail.com>
Co-authored-by: Jilada Eccleston <jilada.eccleston@tier4.jp>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>
Co-authored-by: ito-san <57388357+ito-san@users.noreply.github.com>
Co-authored-by: Shigeki Kobayashi <32808802+sgk-000@users.noreply.github.com>
Co-authored-by: Keisuke Shima <keisuke.shima@tier4.jp>
Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
Co-authored-by: k-obitsu <56008637+k-obitsu@users.noreply.github.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: rej55 <rej55.g@gmail.com>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: yutaka <purewater0901@gmail.com>
Co-authored-by: purewater0901 <43805014+purewater0901@users.noreply.github.com>
Co-authored-by: pre-commit <pre-commit@example.com>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: Takayuki Murooka <takayuki.murooka@tier4.jp>
Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zulfaqar-azmi-t4
Could you also update the paramerter file in autoware_launch?

@zulfaqar-azmi-t4
Copy link
Contributor Author

@tkimura4
Yes sure! I will make a PR for the update.

@zulfaqar-azmi-t4
Copy link
Contributor Author

@tkimura4
The PR for the launch is added here tier4/autoware_launch#384.

The PR aims to replace integer count to time-based.

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 force-pushed the feat/lost-object-hold-using-time-instead-of-count branch from 7f923f3 to 528ab27 Compare July 7, 2022 00:17
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit 774e7fe into autowarefoundation:main Jul 7, 2022
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the feat/lost-object-hold-using-time-instead-of-count branch July 7, 2022 05:17
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
The PR aims to replace integer count to time-based.

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
The PR aims to replace integer count to time-based.

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
The PR aims to replace integer count to time-based.

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…foundation#1142)

The PR aims to replace integer count to time-based.

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
The PR aims to replace integer count to time-based.

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
technolojin pushed a commit to technolojin/autoware.universe that referenced this pull request Apr 9, 2024
…ain-sync

chore: sync beta branch beta/v0.22.0 with tier4/main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants