Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(obstacle_avoidance_planner): add description of max_plan_from_ego_length #1223

Merged
merged 2 commits into from
Jul 4, 2022
Merged

chore(obstacle_avoidance_planner): add description of max_plan_from_ego_length #1223

merged 2 commits into from
Jul 4, 2022

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jul 4, 2022 •
edited
Loading

Description

I added description and param since they were missing in #1191 🙇

Related links

#1191

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kosuke55 kosuke55 marked this pull request as ready for review July 4, 2022 06:36
@kosuke55 kosuke55 force-pushed the feature/plan_from_ego branch 2 times, most recently from 3884086 to 1021297 Compare July 4, 2022 06:40
@kosuke55 kosuke55 changed the title Add description of max_plan_from_ego_length chore(obstacle_avoidance_planner): Add description of max_plan_from_ego_length Jul 4, 2022
@codecov
Copy link

codecov bot commented Jul 4, 2022 •
edited
Loading

Codecov Report

Merging #1223 (1b5a8e1) into main (97d3f70) will increase coverage by 0.04%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##            main   #1223      +/-   ##
========================================
+ Coverage   9.45%   9.50%   +0.04%     
========================================
  Files       1043    1048       +5     
  Lines      66314   72632    +6318     
  Branches   15242   15776     +534     
========================================
+ Hits        6272    6904     +632     
- Misses     54274   59716    +5442     
- Partials    5768    6012     +244
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 9.56% <ø> (+0.10%) ⬆️ Carriedforward from e5ff46b

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...lude/freespace_planning_algorithms/reeds_shepp.hpp 50.00% <0.00%> (-50.00%) ⬇️
.../src/vehicle/test_vehicle_state_checker_helper.hpp 70.58% <0.00%> (-9.42%) ⬇️
planning/behavior_path_planner/test/input.cpp 60.00% <0.00%> (-7.86%) ⬇️
...tier4_autoware_utils/trajectory/tmp_conversion.hpp 60.00% <0.00%> (-6.67%) ⬇️
...oware_auto_geometry/include/geometry/common_2d.hpp 82.66% <0.00%> (-5.91%) ⬇️
...nning/behavior_velocity_planner/test/src/utils.hpp 82.22% <0.00%> (-5.59%) ⬇️
...or/test/src/test_planning_error_monitor_helper.hpp 45.45% <0.00%> (-4.55%) ⬇️
...ning/behavior_path_planner/test/test_utilities.cpp 33.33% <0.00%> (-4.17%) ⬇️
...tion/include/interpolation/interpolation_utils.hpp 54.83% <0.00%> (-3.79%) ⬇️
...ning_evaluator/include/planning_evaluator/stat.hpp 33.33% <0.00%> (-3.04%) ⬇️
... and 686 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97d3f70...1b5a8e1. Read the comment docs.

@kosuke55 kosuke55 changed the title chore(obstacle_avoidance_planner): Add description of max_plan_from_ego_length chore(obstacle_avoidance_planner): Add description of max plan from ego length Jul 4, 2022
@kosuke55
chore(obstacle_avoidance_planner): add description of max_plan_from_e…
e5ff46b 
…go_length

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 changed the title chore(obstacle_avoidance_planner): Add description of max plan from ego length chore(obstacle_avoidance_planner): add description of max_plan_from_ego_length Jul 4, 2022
@kosuke55 kosuke55 requested a review from tkimura4 July 4, 2022 07:36
@kosuke55
fix typo
1b5a8e1 
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@tkimura4 tkimura4 self-requested a review July 4, 2022 07:54
tkimura4
tkimura4 approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

taikitanaka3
taikitanaka3 approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kosuke55
it looks like without this PR obstacle avoidance dies for exception and this PR fix this problem

[ERROR] [launch_ros.actions.load_composable_nodes]: Failed to load node 'obstacle_avoidance_planner' of type 'ObstacleAvoidancePlanner' in container '/planning/scenario_planning/lane_driving/motion_planning/motion_planning_container': Component constructor threw an exception: expected [bool] got [not set]

@kosuke55 kosuke55 merged commit 1495144 into autowarefoundation:main Jul 4, 2022
@kosuke55 kosuke55 deleted the feature/plan_from_ego branch July 4, 2022 09:47
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Jul 5, 2022
Merged
miursh pushed a commit to miursh/autoware.universe that referenced this pull request Jul 12, 2022
@taikitanaka3 @mitsudome-r
@nnmm @jilaada @nik-tier4 @esteve @wep21 @tkimura4 @kenji-miyake @k0suke-murakami @satoshi-ota @s-azumi @h-ohta @KeisukeShima @takayuki5168 @pre-commit-ci @1222-takeshi
feat: add scenario selector package (autowarefoundation#41)
ed10202 
* release v0.4.0

* remove ROS1 packages temporarily

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Revert "remove ROS1 packages temporarily"

This reverts commit 7f877f288151212d5ee578f070fc7e11bd15ad9f.

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* add COLCON_IGNORE to ros1 packages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Rename launch files to launch.xml (autowarefoundation#28)

* ROS2 Porting: scenario_selector (autowarefoundation#101)

* Add cmake and package.xml
 - Remove colcon ignore

* First pass:
 - Remove pubs and subs
 - Remove lane esoteric lanelet method calls

* Add parameter fetching and setting

* Add publishers, logging and transforms
 - Fix createCallback

* Remove duration field from lookuptransform

* Add topic_tools dependency
 - launching of rostopic in ROS1 hasn't been ported?

* Remove comments from cmake

* Remove boost dependency

* Remove test parameters

* Address PR comments:
 - Add const reference back
 - Use initializer list for parameter fetching
 - Fix fromBinMap reference
 - Launch publishing from executable tag in launch file

* Address PR comment:
 - Fix launch file launching of ros2 topic publisher

* Rename h files to hpp (autowarefoundation#142)

* Change includes

* Rename files

* Adjustments to make things compile

* Other packages

* Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143)

* Use quotes for includes where appropriate (autowarefoundation#144)

* Use quotes for includes where appropriate

* Fix lint tests

* Make tests pass hopefully

* fixing trasient_local in ROS2 packages (autowarefoundation#160)

* [scenario_selector_node] fix timer frequency (autowarefoundation#182)

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Add linters to scenario_selector (autowarefoundation#157)

* Added linters to scenario_selector

* Removed duplicate dependencies

* Add linters to CMake

* Only add cppcheck as linter

* Ros2 v0.8.0 scenario selector (autowarefoundation#294)

* add use_sim-time option (autowarefoundation#454)

* Format launch files (autowarefoundation#1219)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* update first tf (autowarefoundation#1223)

* update first tf

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* update

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* Make planning modules components (autowarefoundation#1263)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Remove use_sim_time for set_parameter (autowarefoundation#1260)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* change trajectory callback implementation (autowarefoundation#1338) (autowarefoundation#1355)

* change trajectory callback implementation

* change name of callback function

* remove unnecessary function

* improve readability

Co-authored-by: satoshi-ota <satoshi.ota@gmail.com>

Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: satoshi-ota <satoshi.ota@gmail.com>

* Select LaneDriving scenario if vehicle is in lane and goal is in lane (autowarefoundation#1459) (autowarefoundation#1485)

Signed-off-by: Azumi Suzuki <azumi.suzuki@tier4.jp>
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: s-azumi <38061530+s-azumi@users.noreply.github.com>

* Add markdownlint and prettier (autowarefoundation#1661)

* Add markdownlint and prettier

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore .param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix -Wunused-parameter (autowarefoundation#1836)

* Fix -Wunused-parameter

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix mistake

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix spell

* Fix lint issues

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore flake8 warnings

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>

* add sort-package-xml hook in pre-commit (autowarefoundation#1881)

* add sort xml hook in pre-commit

* change retval to exit_status

* rename

* add prettier plugin-xml

* use early return

* add license note

* add tier4 license

* restore prettier

* change license order

* move local hooks to public repo

* move prettier-xml to pre-commit-hooks-ros

* update version for bug-fix

* apply pre-commit

* Change formatter to clang-format and black (autowarefoundation#2332)

* Revert "Temporarily comment out pre-commit hooks"

This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3.

* Replace ament_lint_common with autoware_lint_common

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove ament_cmake_uncrustify and ament_clang_format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply Black

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix for cpplint

* Fix include double quotes to angle brackets

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add COLCON_IGNORE (autowarefoundation#500)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* port scenario_selector (autowarefoundation#482)

* port scenario_selector

* remove COLCON_IGNORE

* use odom

* add nav_msgs dependency

Co-authored-by: Takayuki Murooka <takayuki.murooka@tier4.jp>

* [apply_predicted_obj_type] adapt to autoware auto msgs (autowarefoundation#564)

* fix obj shape

* fix obj shape

* fix goal pose

* rename topic name twist -> odometry (autowarefoundation#568)

Co-authored-by: Takayuki Murooka <takayuki.murooka@tier4.jp>

* update iv_msgs -> auto_msgs in planning readme (autowarefoundation#576)

* update iv_msgs -> auto_msgs in planning readme

* minor change

* some fix

* some fix

Co-authored-by: Takayuki Murooka <takayuki.murooka@tier4.jp>

* fix scenario selector (autowarefoundation#632)

* ci(pre-commit): autofix

* fix: package title

Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Co-authored-by: Nikolai Morin <nnmmgit@gmail.com>
Co-authored-by: Jilada Eccleston <jilada.eccleston@gmail.com>
Co-authored-by: nik-tier4 <71747268+nik-tier4@users.noreply.github.com>
Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com>
Co-authored-by: Esteve Fernandez <esteve@apache.org>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: satoshi-ota <satoshi.ota@gmail.com>
Co-authored-by: s-azumi <38061530+s-azumi@users.noreply.github.com>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: Takayuki Murooka <takayuki.murooka@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
@kosuke55 @boyali
chore(obstacle_avoidance_planner): add description of max_plan_from_e…
2612d2a 
…go_length (tier4#1223)

* chore(obstacle_avoidance_planner): add description of max_plan_from_ego_length

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix typo

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@kosuke55 @boyali
chore(obstacle_avoidance_planner): add description of max_plan_from_e…
f8e223a 
…go_length (tier4#1223)

* chore(obstacle_avoidance_planner): add description of max_plan_from_ego_length

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix typo

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@kosuke55 @boyali
chore(obstacle_avoidance_planner): add description of max_plan_from_e…
7aa765f 
…go_length (tier4#1223)

* chore(obstacle_avoidance_planner): add description of max_plan_from_ego_length

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix typo

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
@kosuke55
chore(obstacle_avoidance_planner): add description of max_plan_from_e…
c23936a 
…go_length (autowarefoundation#1223)

* chore(obstacle_avoidance_planner): add description of max_plan_from_ego_length

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix typo

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
@kosuke55 @boyali
chore(obstacle_avoidance_planner): add description of max_plan_from_e…
972113c 
…go_length (tier4#1223)

* chore(obstacle_avoidance_planner): add description of max_plan_from_ego_length

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix typo

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Jun 4, 2024
@shmpwk
Merge pull request autowarefoundation#1223 from tier4/cp-lane-change-…
d74c5ca 
…intersection

fix(lane_change): cherry pick for improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkimura4 tkimura4 tkimura4 approved these changes

@taikitanaka3 taikitanaka3 taikitanaka3 approved these changes

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168 takayuki5168 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kosuke55 @tkimura4 @taikitanaka3