Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(map based prediction): use polling subscriber #7397

Merged
merged 1 commit into from
Jun 11, 2024
Merged

feat(map based prediction): use polling subscriber #7397

merged 1 commit into from
Jun 11, 2024

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Jun 10, 2024

Description

Related links

Tests performed

Notes for reviewers

Interface changes

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jun 10, 2024
@soblin
feat(map_based_prediction): use polling subscriber
2f980dd 
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin force-pushed the feat/map_based_prediction-polling-sub branch from 93d230a to 2f980dd Compare June 10, 2024 07:15
@github-actions github-actions bot removed type:documentation Creating or refining documentation. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jun 10, 2024
@soblin soblin marked this pull request as ready for review June 11, 2024 04:38
@soblin soblin added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 11, 2024
yuki-takagi-66
yuki-takagi-66 approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soblin soblin merged commit 2551d99 into autowarefoundation:main Jun 11, 2024
33 of 34 checks passed
@soblin soblin deleted the feat/map_based_prediction-polling-sub branch June 11, 2024 05:03
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
@soblin @KhalilSelyan
feat(map based prediction): use polling subscriber (#7397)
baf0d4e 
feat(map_based_prediction): use polling subscriber

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuki-takagi-66 yuki-takagi-66 yuki-takagi-66 approved these changes

Assignees
No one assigned
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soblin @yuki-takagi-66