fix(autoware_traffic_light_visualization): fix to visualize correct color and shapes #8428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:perception
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
3 tasks
ktro2828
force-pushed
the
fix/perception/tlr-visualization
branch
2 times, most recently
from
76422af to
14f2378
Compare
…rrect shapes Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
ktro2828
force-pushed
the
fix/perception/tlr-visualization
branch
from
14f2378 to
8640806
Compare
KhalilSelyan
approved these changes
Aug 12, 2024
ktro2828
added
the
run:build-and-test-differential
|
@tzhong518 Could you review this PR as a code owner? 🙏 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8428 +/- ##
==========================================
- Coverage 23.88% 23.73% -0.16%
==========================================
Files 1380 1379 -1
Lines 101867 101018 -849
Branches 38781 38320 -461
==========================================
- Hits 24334 23974 -360
+ Misses 75000 74575 -425
+ Partials 2533 2469 -64
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tzhong518
approved these changes
Aug 15, 2024
saka1-s
pushed a commit
to saka1-s/autoware.universe
that referenced
this pull request
Nov 1, 2024
…olor and shapes (autowarefoundation#8428) fix(autoware_traffic_light_visualization): fix vialization to draw correct shapes Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp> Co-authored-by: Yi-Hsiang Fang (Vivid) <146902905+vividf@users.noreply.github.com>
saka1-s
pushed a commit
to saka1-s/autoware.universe
that referenced
this pull request
Nov 1, 2024
…olor and shapes (autowarefoundation#8428) fix(autoware_traffic_light_visualization): fix vialization to draw correct shapes Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp> Co-authored-by: Yi-Hsiang Fang (Vivid) <146902905+vividf@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #8389.
The visualization result of after this PR:
Screencast.from.2024.08.09.17.12.07.webm
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.