Skip to content

Conversation

@orenergy
Copy link

This will allow this library to work with modules with MCP2515+TJA1080+8MHz oscillator crystall.
This request depends on request at arduino-canhacker project

Use them when setting bitrate
@autowp
Copy link
Owner

autowp commented Jan 15, 2017

Looks great.
What you think about change type of canClock to enum like CAN_SPEED enum to prevent using of other values than 8, 16, 20?

Are you update corresponding examples, README.md?

@orenergy
Copy link
Author

Didn't touched README and examples.
Ideally there's no need to change anything if you have module with 16MHZ (it's default for compatibility), but I'll write couple of lines about it in readme.

@orenergy
Copy link
Author

Updated my request with your corrections. Please review

@autowp autowp merged commit 7d28c94 into autowp:master Jan 16, 2017
autowp pushed a commit that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants