Skip to content

More appropriate return code for sendMessage method #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2020
Merged

More appropriate return code for sendMessage method #34

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be8ad40
Return ERROR_ALLTXBUSY when three TX buffers are all busy
jxltom Mar 18, 2020
7dbf333
Check success status after sending message
jxltom Mar 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion mcp2515.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,6 +591,10 @@ MCP2515::ERROR MCP2515::sendMessage(const TXBn txbn, const struct can_frame *fra

modifyRegister(txbuf->CTRL, TXB_TXREQ, TXB_TXREQ);

uint8_t ctrl = readRegister(txbuf->CTRL);
if ((ctrl & (TXB_ABTF | TXB_MLOA | TXB_TXERR)) != 0) {
return ERROR_FAILTX;
}
return ERROR_OK;
}

Expand All @@ -610,7 +614,7 @@ MCP2515::ERROR MCP2515::sendMessage(const struct can_frame *frame)
}
}

return ERROR_FAILTX;
return ERROR_ALLTXBUSY;
}

MCP2515::ERROR MCP2515::readMessage(const RXBn rxbn, struct can_frame *frame)
Expand Down