Add support for documentHighlight in vim8 #1123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martskins
force-pushed
the
fix-document-highlight
branch
from
4ff8777 to
8516db8
Compare
martskins
force-pushed
the
fix-document-highlight
branch
from
8516db8 to
a0cf846
Compare
martskins
added a commit
to martskins/LanguageClient-neovim
that referenced
this pull request
Dec 6, 2020
martskins
added a commit
to martskins/LanguageClient-neovim
that referenced
this pull request
Dec 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the implementation of
text_document_document_highlightin order to add support for it in vim8 as well as neovim. I also removed thehighlight_sourcestate as we can just clear the namespace and current buffer always, which sounds like a reasonable thing to do anyways.Fixes #1018