Fix start_server implementation #1124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martskins
force-pushed
the
fix-start-server
branch
from
845ac24 to
971d6e1
Compare
martskins
added a commit
to martskins/LanguageClient-neovim
that referenced
this pull request
Dec 6, 2020
martskins
added a commit
to martskins/LanguageClient-neovim
that referenced
this pull request
Dec 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the calls to
did_openanddid_changeinside ourstart_serverimplementation as errors from those could be misleading in indicating that the server had failed. Also, the call todid_changeI think isn't really necessary since we're already sending the text insidedid_open.