Skip to content

Prefer T::deserialize over T::from_value to avoid clone #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2020
Merged

Prefer T::deserialize over T::from_value to avoid clone #1130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/vim.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,17 @@ use anyhow::Result;
use jsonrpc_core::Value;
use log::*;
use lsp_types::Position;
use serde::{de::DeserializeOwned, Serialize};
use serde::{de::DeserializeOwned, Deserialize, Serialize};
use serde_json::json;
use std::{path::Path, sync::Arc};

/// Try get value of an variable from RPC params.
pub fn try_get<R: DeserializeOwned>(key: &str, params: &Value) -> Result<Option<R>> {
pub fn try_get<'a, R: Deserialize<'a>>(key: &str, params: &'a Value) -> Result<Option<R>> {
let value = &params[key];
if value == &Value::Null {
Ok(None)
} else {
Ok(serde_json::from_value(value.clone())?)
Ok(<Option<R>>::deserialize(value)?)
}
}

Expand Down