Add a clients_mutex for starting new language servers #881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autozimu
reviewed
Sep 17, 2019
src/language_client.rs
Outdated
| pub fn lock_clients_update(&self) -> Fallible<MutexGuard<()>> { | ||
| self.clients_mutex | ||
| .lock() | ||
| .map_err(|err| format_err!("Failed to lock state: {:?}", err)) |
Owner
There was a problem hiding this comment.
This error message shall be update to ... lock client creation
Owner
|
Can you upgrade to take languageId into consideration? Say user invoke vim with Sorry didn't bring up in the first contact. |
This prevents more than one language server (per languageId) from starting up at any point in time. Fixes autozimu#878
TysonAndre
force-pushed
the
add-clients_mutex
branch
from
453ccb6 to
a011df1
Compare
Contributor
Author
The review comments have been addressed, this is ready for another look |
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents more than one language server from starting up at any
point in time.
Fixes #878