Apply state modifications once #2473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return fmt.Errorf("%w %s", errMissingBlockState, parentID) | ||
| } | ||
| if parentState.onDecisionState != nil { | ||
| if err := parentState.onDecisionState.Apply(a.state); err != nil { |
Contributor
There was a problem hiding this comment.
To confirm, just calling the onAcceptState doesn't commit all diffs under it (for example the wrapped decision state)?
Contributor
Author
There was a problem hiding this comment.
That's correct
Contributor
Author
There was a problem hiding this comment.
We could apply the onAcceptState to onDecisionState and then apply onDecisionState to a.state if you felt that was cleaner... But this is the (slightly) more efficient way to do the same thing.
Contributor
There was a problem hiding this comment.
I think what we have here is fine. Makes sense (should be the same thing).
patrick-ogrady
approved these changes
Dec 12, 2023
dhrubabasu
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
How this works
Moves state application from verification to accept.
How this was tested