Skip to content

Conversation

StephenButtolph
Copy link
Contributor

Why this should be merged

While not all mocks are bad - these are. 🧹

How this works

  • Uses real iterator implementations rather than mocked implementations.
  • Deletes the mocked iterator implementation.

How this was tested

  • CI

@StephenButtolph StephenButtolph added the cleanup Code quality improvement label Sep 25, 2024
@StephenButtolph StephenButtolph added this to the v1.11.12 milestone Sep 25, 2024
@StephenButtolph StephenButtolph self-assigned this Sep 25, 2024
Copy link
Contributor

@ARR4N ARR4N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While not all mocks are bad

Such diplomacy

@StephenButtolph StephenButtolph merged commit 2ebcde4 into master Sep 25, 2024
21 of 22 checks passed
@StephenButtolph StephenButtolph deleted the remove-mocked-iterator branch September 25, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Code quality improvement

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants