Cleanup the version package #4465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the version package by removing unnecessary abstractions and improving code clarity. The changes replace error-based compatibility checking with boolean returns, eliminate the Compatibility interface in favor of a concrete type, and modernize version comparison using the cmp package.
Key changes:
- Replaced
errorreturns withboolin compatibility checking - Removed the
Compatibilityinterface, using*Compatibilityconcrete type instead - Updated version comparison to use
cmp.Comparefor clearer semantics
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| version/version.go | Switched from atomic.Value to sync.Once for string caching; updated Compare to use cmp.Compare and changed parameter type from *Semantic to *Application |
| version/constants.go | Changed GetCompatibility return type from Compatibility to *Compatibility and reordered parameters |
| version/compatibility_test.go | Updated test expectations from error assertions to boolean checks; renamed variables for clarity |
| version/compatibility.go | Removed Compatibility interface and error constants; simplified compatibility logic to return bool instead of error |
| version/application_test.go | Removed compatibility-related test cases following deletion of Compatible method |
| version/application.go | Removed Compatible method and error constants; updated Compare to use cmp.Compare |
| network/peer/peer.go | Updated compatibility checks to use boolean returns and added version logging |
| network/peer/config.go | Changed VersionCompatibility field type from version.Compatibility to *version.Compatibility |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Stephen Buttolph <stephen@avalabs.org>
alarso16
approved these changes
Nov 5, 2025
joshua-kim
reviewed
Nov 5, 2025
This comment has been minimized.
This comment has been minimized.
joshua-kim
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
errorwith aboolSemanticBeforeHow this works
A cleanup that I factored out of my wip of the version logging work.
How this was tested
CI
Need to be documented in RELEASES.md?
No