-
Notifications
You must be signed in to change notification settings - Fork 174
Implement ConvertSubnetTx #885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
erictaylor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good.
Left some initial comments. Let's make sure we are adding test coverage.
|
Thank you! Also, could you please add the new builder function to the etna-examples folder? Feel free to add |
68a91d7 to
5d7b771
Compare
Tests and fixes for ConvertSubnetTx
erictaylor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Couple small cleanup requests.
rictorlome
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Can this be added to the burn checker as well?
This PR adds
ConvertSubnetTxto pvm etna builder.added
ConvertSubnetTxto pvm codec at index 35added serializable object
ConvertSubnetTxandConvertSubnetValidatormoved
getMemoComplexityto pvm/txs/fee/complexity.ts and renamed it togetBytesComplexity.added
getSubnetValidatorsComplexityandconvertSubnetTxto pvm/txs/fee/complexity.tsadded
INTRINSIC_CONVERT_SUBNET_VALIDATOR_COMPLEXITIESandINTRINSIC_CONVERT_SUBNET_TX_COMPLEXITIESadded
isConvertSubnetTxtypeguardadd
NODE_ID,BLS_SIGNATURE, andBLS_PUBLIC_KEYto getEnvVars. which gets the value from info.getNodeId for the networkadded examples to
createSubnetTx,createChainTx,convertSubnetTx-
createSubnetTxandcreateChainTxhave to be issued first beforeconvertSubnetTxcan be issued.Successful txs in etna explorer for address
P-custom1s4k9fch6uyhvv7necq070nzljgrqvazkpgles6: