Skip to content

refactor: move core/types to plugin/evm/types #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 14, 2025
Merged

refactor: move core/types to plugin/evm/types #877

merged 2 commits into from
Mar 14, 2025

Conversation

ARR4N
Copy link
Collaborator

@ARR4N ARR4N commented Mar 14, 2025 •
edited
Loading

Why this should be merged

The types package now only contains coreth logic an nothing from upstream so it shouldn't live in the same location in the repo.

How this works

Automated:

$ git mv core/types plugin/evm/types
$ find -name '*.go' | xargs sed -i 's|"github.com/ava-labs/coreth/core/types"|"github.com/ava-labs/coreth/plugin/evm/types"|'
$ golangci-lint run --fix

How this was tested

CI; existing tests are sufficient because this merely moves an entire package.

Need to be documented?

No

Need to update RELEASES.md?

No

@ARR4N ARR4N mentioned this pull request Mar 14, 2025
Merged
@ARR4N ARR4N marked this pull request as ready for review March 14, 2025 20:02
@ARR4N ARR4N requested review from a team, ceyonur and darioush as code owners March 14, 2025 20:02
@ARR4N ARR4N enabled auto-merge (squash) March 14, 2025 20:03
@ARR4N ARR4N merged commit 33638ed into libevm Mar 14, 2025
6 checks passed
@ARR4N ARR4N deleted the arr4n/move-customtypes branch March 14, 2025 21:02
qdm12 pushed a commit to ava-labs/subnet-evm that referenced this pull request Mar 19, 2025
@ARR4N @qdm12
refactor: move core/types to plugin/evm/types
b41a3bc 
The `types` package now only contains `coreth` logic an nothing from upstream so it shouldn't live in the same location in the repo.

Automated:

```shell
$ git mv core/types plugin/evm/types
$ find -name '*.go' | xargs sed -i 's|"github.com/ava-labs/coreth/core/types"|"github.com/ava-labs/coreth/plugin/evm/types"|'
$ golangci-lint run --fix
```

See original PR ava-labs/coreth#877
qdm12 pushed a commit to ava-labs/subnet-evm that referenced this pull request Mar 19, 2025
@ARR4N @qdm12
refactor: move core/types to plugin/evm/types
4033f17 
The `types` package now only contains `coreth` logic an nothing from upstream so it shouldn't live in the same location in the repo.

Automated:

```shell
$ git mv core/types plugin/evm/types
$ find -name '*.go' | xargs sed -i 's|"github.com/ava-labs/coreth/core/types"|"github.com/ava-labs/coreth/plugin/evm/types"|'
$ golangci-lint run --fix
```

See original PR ava-labs/coreth#877
qdm12 pushed a commit to ava-labs/subnet-evm that referenced this pull request Mar 21, 2025
@ARR4N @qdm12
refactor: move core/types to plugin/evm/types
06ebc8e 
The `types` package now only contains `coreth` logic an nothing from upstream so it shouldn't live in the same location in the repo.

Automated:

```shell
$ git mv core/types plugin/evm/types
$ find -name '*.go' | xargs sed -i 's|"github.com/ava-labs/coreth/core/types"|"github.com/ava-labs/coreth/plugin/evm/types"|'
$ golangci-lint run --fix
```

See original PR ava-labs/coreth#877
qdm12 pushed a commit to ava-labs/subnet-evm that referenced this pull request Mar 21, 2025
@ARR4N @qdm12
refactor: move core/types to plugin/evm/types
c4a0e2a 
The `types` package now only contains `coreth` logic an nothing from upstream so it shouldn't live in the same location in the repo.

Automated:

```shell
$ git mv core/types plugin/evm/types
$ find -name '*.go' | xargs sed -i 's|"github.com/ava-labs/coreth/core/types"|"github.com/ava-labs/coreth/plugin/evm/types"|'
$ golangci-lint run --fix
```

See original PR ava-labs/coreth#877
qdm12 pushed a commit that referenced this pull request Mar 24, 2025
@ARR4N @qdm12
refactor: move core/types to plugin/evm/types (#877)
f0de355 
## Why this should be merged

The `types` package now only contains `coreth` logic an nothing from upstream so it shouldn't live in the same location in the repo.

## How this works

Automated:

```shell
$ git mv core/types plugin/evm/types
$ find -name '*.go' | xargs sed -i 's|"github.com/ava-labs/coreth/core/types"|"github.com/ava-labs/coreth/plugin/evm/types"|'
$ golangci-lint run --fix
```
qdm12 pushed a commit to ava-labs/subnet-evm that referenced this pull request Mar 24, 2025
@ARR4N @qdm12
refactor: move core/types to plugin/evm/types
aaf31f1 
The `types` package now only contains `coreth` logic an nothing from upstream so it shouldn't live in the same location in the repo.

Automated:

```shell
$ git mv core/types plugin/evm/types
$ find -name '*.go' | xargs sed -i 's|"github.com/ava-labs/coreth/core/types"|"github.com/ava-labs/coreth/plugin/evm/types"|'
$ golangci-lint run --fix
```

See original PR ava-labs/coreth#877
qdm12 pushed a commit to ava-labs/subnet-evm that referenced this pull request Mar 24, 2025
@ARR4N @qdm12
refactor: move core/types to plugin/evm/types
f6c95f9 
The `types` package now only contains `coreth` logic an nothing from upstream so it shouldn't live in the same location in the repo.

Automated:

```shell
$ git mv core/types plugin/evm/types
$ find -name '*.go' | xargs sed -i 's|"github.com/ava-labs/coreth/core/types"|"github.com/ava-labs/coreth/plugin/evm/types"|'
$ golangci-lint run --fix
```

See original PR ava-labs/coreth#877
qdm12 pushed a commit that referenced this pull request Mar 24, 2025
@ARR4N @qdm12
refactor: move core/types to plugin/evm/types (#877)
e6835a6 
## Why this should be merged

The `types` package now only contains `coreth` logic an nothing from upstream so it shouldn't live in the same location in the repo.

## How this works

Automated:

```shell
$ git mv core/types plugin/evm/types
$ find -name '*.go' | xargs sed -i 's|"github.com/ava-labs/coreth/core/types"|"github.com/ava-labs/coreth/plugin/evm/types"|'
$ golangci-lint run --fix
```
qdm12 pushed a commit to ava-labs/subnet-evm that referenced this pull request Mar 24, 2025
@ARR4N @qdm12
refactor: move core/types to plugin/evm/types
edf98cc 
The `types` package now only contains `coreth` logic an nothing from upstream so it shouldn't live in the same location in the repo.

Automated:

```shell
$ git mv core/types plugin/evm/types
$ find -name '*.go' | xargs sed -i 's|"github.com/ava-labs/coreth/core/types"|"github.com/ava-labs/coreth/plugin/evm/types"|'
$ golangci-lint run --fix
```

See original PR ava-labs/coreth#877
qdm12 pushed a commit to ava-labs/subnet-evm that referenced this pull request Mar 28, 2025
@ARR4N @qdm12
refactor: move core/types to plugin/evm/types
e83d144 
The `types` package now only contains `coreth` logic an nothing from upstream so it shouldn't live in the same location in the repo.

Automated:

```shell
$ git mv core/types plugin/evm/types
$ find -name '*.go' | xargs sed -i 's|"github.com/ava-labs/coreth/core/types"|"github.com/ava-labs/coreth/plugin/evm/types"|'
$ golangci-lint run --fix
```

See original PR ava-labs/coreth#877
qdm12 pushed a commit to ava-labs/subnet-evm that referenced this pull request Apr 1, 2025
@ARR4N @qdm12
refactor: move core/types to plugin/evm/types
d393209 
The `types` package now only contains `coreth` logic an nothing from upstream so it shouldn't live in the same location in the repo.

Automated:

```shell
$ git mv core/types plugin/evm/types
$ find -name '*.go' | xargs sed -i 's|"github.com/ava-labs/coreth/core/types"|"github.com/ava-labs/coreth/plugin/evm/types"|'
$ golangci-lint run --fix
```

See original PR ava-labs/coreth#877
@qdm12 qdm12 mentioned this pull request Apr 8, 2025
Merged
node-druidx56y added a commit to node-druidx56y/subnet-evm that referenced this pull request Sep 28, 2025
@node-druidx56y
refactor: move core/types to plugin/evm/types
b6cecf1 
The `types` package now only contains `coreth` logic an nothing from upstream so it shouldn't live in the same location in the repo.

Automated:

```shell
$ git mv core/types plugin/evm/types
$ find -name '*.go' | xargs sed -i 's|"github.com/ava-labs/coreth/core/types"|"github.com/ava-labs/coreth/plugin/evm/types"|'
$ golangci-lint run --fix
```

See original PR ava-labs/coreth#877
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maru-ava maru-ava maru-ava approved these changes

@ceyonur ceyonur Awaiting requested review from ceyonur ceyonur is a code owner

+1 more reviewer

@darioush darioush darioush approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ARR4N @darioush @maru-ava