Skip to content

Conversation

@qdm12
Copy link

@qdm12 qdm12 commented Feb 11, 2025

Why this should be merged

So we don't forget to tidy dependencies before merging to main branch.

How this works

  • Run go mod tidy
  • Add CI job to check go modules are tidy

How this was tested

CI passing

@ARR4N
Copy link
Collaborator

ARR4N commented Feb 11, 2025

Is there a way we can guarantee that it doesn't change the versions?

@qdm12
Copy link
Author

qdm12 commented Feb 11, 2025

Is there a way we can guarantee that it doesn't change the versions?

go mod tidy should not change versions except for indirect dependencies I believe; We can always remove it later in case it does in fact change a direct dependency version in a later PR, which we would see in the go.mod PR diffs.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed no change in versions.

@qdm12 qdm12 merged commit 2580bd1 into main Feb 11, 2025
6 checks passed
@qdm12 qdm12 deleted the qdm12/deps-tidy branch February 11, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants