feat(core/types): body RLP hooks registration #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
force-pushed
the
qdm12/core/types/body-hooks-rlp
branch
from
f037b1a to
9fe07d4
Compare
qdm12
commented
Feb 11, 2025
qdm12
force-pushed
the
qdm12/core/types/body-hooks-rlp
branch
2 times, most recently
from
30145a2 to
5cc4a70
Compare
ARR4N
reviewed
Feb 11, 2025
ARR4N
reviewed
Feb 11, 2025
ARR4N
reviewed
Feb 11, 2025
ARR4N
reviewed
Feb 11, 2025
2 tasks
qdm12
force-pushed
the
qdm12/core/types/body-hooks-rlp
branch
from
de572a1 to
99c0b34
Compare
qdm12
force-pushed
the
qdm12/core/types/body-hooks-rlp
branch
3 times, most recently
from
3ff6b2c to
0f2b8ee
Compare
ARR4N
requested changes
Feb 11, 2025
Co-authored-by: Arran Schlosberg <519948+ARR4N@users.noreply.github.com>
Co-authored-by: Arran Schlosberg <519948+ARR4N@users.noreply.github.com>
qdm12
force-pushed
the
qdm12/core/types/body-hooks-rlp
branch
from
d3fc726 to
2c46b58
Compare
ARR4N
requested changes
Feb 12, 2025
ARR4N
added a commit
that referenced
this pull request
Feb 12, 2025
…types_test` (#131) ## Why this should be merged Simplify testing in #130. ## How this works Backwards-compatibility tests were originally created in `package types_test` because the first one uses `ethtest` and would have caused a circular dependency. None of the later tests have this issue so they were moved into `package types`. The `cmpeth` test utility isn't currently needed anywhere else so its functionality is collapsed inside this new file. ## How this was tested N/A as simply moving existing tests to different files.
ARR4N
approved these changes
Feb 12, 2025
Comment on lines
+89
to
+90
| require.NoErrorf(t, err, "rlp.DecodeBytes(rlp.EncodeToBytes(%T), %T) resulted in %s", | ||
| (*withoutMethods)(body), got, pretty.Sprint(got)) |
There was a problem hiding this comment.
Suggested change
| require.NoErrorf(t, err, "rlp.DecodeBytes(rlp.EncodeToBytes(%T), %T) resulted in %s", | |
| (*withoutMethods)(body), got, pretty.Sprint(got)) | |
| require.NoErrorf( | |
| t, err, "rlp.DecodeBytes(rlp.EncodeToBytes(%T), %T) resulted in %s", | |
| (*withoutMethods)(body), got, pretty.Sprint(got), | |
| ) |
This isn't 🐍 Python 😛
There was a problem hiding this comment.
Didn't see the auto merge. I'll do it in my PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Allow to register body extras in consumers of libevm.
How this works
How this was tested
Existing tests modified.