Skip to content

fix: run flaky upstream tests sequentially #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 12, 2024
Merged

fix: run flaky upstream tests sequentially #15

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b869f36
fix: run flaky upstream tests sequentially
ARR4N Sep 12, 2024
e0e6a7d
chore: run flaky tests first to fail early
ARR4N Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/go.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,7 @@ jobs:
with:
go-version: 1.21.4
- name: Run tests
run: go test -short $(go list ./... | grep -Pv 'go-ethereum/(accounts/keystore|eth/downloader|miner)$')
run: | # Upstream flakes are race conditions exacerbated by concurrent tests
FLAKY_REGEX='go-ethereum/(eth|accounts/keystore|eth/downloader|miner)$';
go list ./... | grep -P "${FLAKY_REGEX}" | xargs -n 1 go test -short;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a heads up that -P isn't supported on mac

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I forgot because I very quickly installed GNU tools when I got one!

When we extend CI testing beyond this basic one we should discuss the extent to which we want to run upstream tests in different environments, given that they already do it extensively.

go test -short $(go list ./... | grep -Pv "${FLAKY_REGEX}");
Loading