chore: logging #151
Merged
chore: logging #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARR4N
commented
Feb 21, 2025
| defer func() { | ||
| active = rules.Hooks().ActivePrecompiles(append([]common.Address{}, active...)) | ||
| }() | ||
| func activePrecompiles(rules params.Rules) []common.Address { |
There was a problem hiding this comment.
Other than not being exported, this is now identical to the geth@v1.13.14 implementation.
darioush
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Adds logging of
libevmmodification of default behaviour.How this works
log.Lazyfunctions to allow expensive logging operations to be computed i.f.f. required by the logging level.Infologging for registration of types andDebuglogging for all else.set, was necessary because we don't want to depend onavalanchegoand thehashicorp/go-setlatest version requires a later version of Go. refactor: usehashicorp/go-setwhen on Go 1.23+ #153 tracks a swap to the latter when possible.The
eth/tracers/internal/tracetesttest flaked at least twice (unrelated to these changes) so I've marked it as such since it's not worth a separate PR.How this was tested
New unit test on
log.Lazy+setmethods. Existing CI for the rest as it's a refactor.