forked from ethereum/go-ethereum
    
        
        - 
                Notifications
    You must be signed in to change notification settings 
- Fork 5
chore(ci): add yaml linter workflow and fix yaml formatting #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            8 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      e54be71
              
                chore(ci): add yaml linter workflow
              
              
                qdm12 e7b60e9
              
                Fix existing yml files to pass CI
              
              
                qdm12 98fe0b6
              
                Comment on why specific yml files are ignored
              
              
                qdm12 bf3a406
              
                Specify reason for blocked module ethereum/go-ethereum
              
              
                qdm12 387fffc
              
                Specify reason for blocked module ava-labs/coreth
              
              
                qdm12 41cd230
              
                Specify reason for blocked module ava-labs/subnet-evm
              
              
                qdm12 a4743cc
              
                Specify reason for blocked module ava-labs/avalanchego
              
              
                qdm12 a4b5f69
              
                Move yamlint config to .yamlint.yml
              
              
                qdm12 File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| name: YAML check | ||
|  | ||
| on: | ||
| pull_request: | ||
| branches: [main] | ||
| paths: | ||
| - "**/*.yml" | ||
| - "**/*.yaml" | ||
| - ".github/workflows/yml.yml" | ||
| - ".github/yamllint.yml" | ||
|  | ||
| jobs: | ||
| yaml-check: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Validate YAML files | ||
| run: yamllint -c .yamllint.yml . | ||
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| extends: default | ||
|  | ||
| rules: | ||
| document-start: disable | ||
| line-length: disable | ||
| comments: | ||
| min-spaces-from-content: 1 | ||
| truthy: | ||
| check-keys: false | ||
| ignore: | ||
| # Upstream geth files that we don't want to modify unnecessarily. | ||
| - .travis.yml | ||
| - crypto/secp256k1/libsecp256k1/.travis.yml | 
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of interest, why are these two explicitly required?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just so the (non required) workflow only triggers when modifying .yml/.yaml files. I suppose the workflow is yml too, so no need to specify it, but I really added it out of habit without thinking this through 😄 Although thinking about it, it might be worth leaving it in case someone copies the workflow (i.e. to make a markdown one) so he/she doesn't forget to have a trigger file path on the workflow file itself.