feat: blocks package
#18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Stephen Buttolph <stephen@avalabs.org> Signed-off-by: Arran Schlosberg <519948+ARR4N@users.noreply.github.com>
Co-authored-by: Stephen Buttolph <stephen@avalabs.org> Signed-off-by: Arran Schlosberg <519948+ARR4N@users.noreply.github.com>
Co-authored-by: Stephen Buttolph <stephen@avalabs.org> Signed-off-by: Arran Schlosberg <519948+ARR4N@users.noreply.github.com>
StephenButtolph
approved these changes
Sep 25, 2025
blocks/settlement.go
Outdated
Comment on lines
89
to
90
| // LastSettled returns the last-settled block at the time of b's acceptance, | ||
| // unless [Block.MarkSettled] has been called, in which case it returns nil. If |
Contributor
There was a problem hiding this comment.
pedantic: but if I were to read this doc, I would assume it is expected for me to be able to call this even after MarkSettled has been called. However, that results in an ERROR log.
Collaborator
Author
There was a problem hiding this comment.
WAI but insufficiently documented (and since updated). We could debate whether it should be WARN vs ERROR, but it definitely needs to be something because it points to improper usage in the build-verify-accept loop.
Co-authored-by: Stephen Buttolph <stephen@avalabs.org> Signed-off-by: Arran Schlosberg <519948+ARR4N@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the
blocks.Blocktype (and associated helpers), which satisfies theadaptor.BlockPropertiesinterface introduced in #7. While the motivation of specific functionality may not be clear in isolation, context can be garnered from the prototype code (f79aff0) and how it uses this package insaexecand the primary SAE implementation.Recommended review order:
block.go- general scaffolding and constructionsnow.go- implementation ofadaptor.BlockPropertiesmethodsexecution.go- transition from Accepted to Executedsettlement.go- transition from Executed to Settled; and also inspection of existing/hypothetical settlement (for block building)db.go- database functionality used by the above, co-located for shared logicblockspackageTests can be reviewed either immediately after their respective non-test file, or batched at the end. Review the
cmputilsandsaetestadditions before reviewing any tests.Closes #12.