Skip to content

sync: coreth PR #1182: style: enable nilerr linter #1750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 1, 2025
Merged

sync: coreth PR #1182: style: enable nilerr linter #1750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35a1eb9
style: enable nilerr linter (#1182)
JonathanOppenheimer Sep 4, 2025
a1bc9f9
lint
JonathanOppenheimer Sep 29, 2025
22635ad
Merge branch 'master' into JonathanOppenheimer/sync-pr-1182-lint-enab…
JonathanOppenheimer Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .avalanche-golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ linters:
- ineffassign
- misspell
- nakedret
# - nilerr
- nilerr
- noctx
- nolintlint
- perfsprint
Expand Down
3 changes: 1 addition & 2 deletions plugin/evm/customtypes/rlp_fuzzer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,7 @@ import (

func decodeEncode(input []byte, val interface{}) error {
if err := rlp.DecodeBytes(input, val); err != nil {
// not valid rlp, nothing to do
return nil
return nil //nolint:nilerr // not valid rlp, nothing to do
}
// If it _were_ valid rlp, we can encode it again
output, err := rlp.EncodeToBytes(val)
Expand Down
2 changes: 1 addition & 1 deletion sync/statesync/trie_sync_tasks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ func (s *storageTrieTask) OnStart() (bool, error) {
}
storageTrie, err := trie.New(trie.StorageTrieID(s.sync.root, s.root, firstAccount), s.sync.trieDB)
if err != nil {
return false, nil
return false, nil //nolint:nilerr // the storage trie does not exist, so it should be rerequested
}

// If the storage trie is already on disk, we only need to populate the storage snapshot for [accountHash]
Expand Down