Conversation
PaulaSp3
requested changes
Sep 8, 2025
fso42
changed the title
fso42
approved these changes
Sep 8, 2025
PaulaSp3
approved these changes
Sep 8, 2025
fso42
approved these changes
Sep 10, 2025
awirb
commented
Sep 10, 2025
Co-authored-by: Paula Spannring <95042192+PaulaSp3@users.noreply.github.com>
stopped particles are always and only deleted and stored in stoppedParticles when surface is adapted due to stopping little comment Update avaframe/com1DFA/DFAfunctionsCython.pyx Co-authored-by: Anna Wirbel <68687423+awirb@users.noreply.github.com>
Contributor
|
Standardtests ident |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if mass of a particle becomes 0 (e.g. because of detrainment) previously particle was removed after dividing by m=0 and resulting inf or nan velocities - that lead to new particle positions that caused iCellNew < 0
now first check if m=0, then continue with next particle and remove this one
TODO - update docu-> @PaulaSp3