Conversation
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #886 +/- ##
==========================================
- Coverage 75.18% 75.05% -0.13%
==========================================
Files 62 62
Lines 13837 13894 +57
==========================================
+ Hits 10403 10428 +25
- Misses 3434 3466 +32
☔ View full report in Codecov by Sentry. |
fso42
requested changes
Aug 8, 2023
use com1DFA_override in probAnaCfg.ini and remove option for providing a file path to com1DFACfg and update contourplots to show all lines
|
Code Climate has analyzed commit 5d83a53 and detected 11 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 61.1% (50% is the threshold). This pull request will bring the total coverage in the repository to 75.0% (0.0% change). View more on Code Climate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update runAna4ProbAna – com1DFA settings from com1DFA_override in probAnaCfg.ini and either default com1DFA cfg if com1DFA_override – defaultConfig=True if not and a local_com1DFACfg is available use this too combine with parameters in com1DFA_override
check if desired simType for com1DFA is a valid option [null, ent, res, entres, available]
contour line plots – if one contour line is made up by multiple lines – make it still a nice plot
create a sample plot for probAna if the created sample has a variation of two parameters
but one of them is a thickness parameter and has multiple featues e.g. relTh0, relTh1,
the thickness is varied for the individual thickness features in the same way (same percent variation) and add now a plot that has multiple y axis to cover all the features