Skip to content

fix bug in checking for matplotlibversion#916

Merged
fso42 merged 1 commit intomasterfrom
fixMV
Sep 21, 2023
Merged

fix bug in checking for matplotlibversion#916
fso42 merged 1 commit intomasterfrom
fixMV

Conversation

@awirb
Copy link
Copy Markdown
Contributor

@awirb awirb commented Sep 21, 2023

No description provided.

@awirb awirb added the confirmed Something isn't working label Sep 21, 2023
@awirb awirb requested a review from fso42 September 21, 2023 08:42
@pep8speaks
Copy link
Copy Markdown

Hello @awirb! Thanks for opening this PR.

Line 888:121: E501 line too long (122 > 120 characters)
Line 888:93: E231 missing whitespace after ':'
Line 888:40: E225 missing whitespace around operator
Line 546:15: E711 comparison to None should be 'if cond is not None:'
Line 510:71: E203 whitespace before ':'
Line 510:48: E203 whitespace before ':'
Line 504:71: E203 whitespace before ':'
Line 504:48: E203 whitespace before ':'

Do see the Hitchhiker's guide to code style

@qlty-cloud-legacy
Copy link
Copy Markdown

Code Climate has analyzed commit da32e9f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 73.6% (0.0% change).

View more on Code Climate.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage: 90.15% and project coverage change: +0.15% 🎉

Comparison is base (892f56d) 73.49% compared to head (da32e9f) 73.65%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #916      +/-   ##
==========================================
+ Coverage   73.49%   73.65%   +0.15%     
==========================================
  Files          63       63              
  Lines       14478    14551      +73     
==========================================
+ Hits        10641    10717      +76     
+ Misses       3837     3834       -3     
Files Changed Coverage Δ
avaframe/out3Plot/plotUtils.py 93.62% <85.71%> (-0.38%) ⬇️
avaframe/out3Plot/outAIMEC.py 81.03% <86.25%> (+0.83%) ⬆️
avaframe/ana3AIMEC/aimecTools.py 81.29% <100.00%> (+0.11%) ⬆️
avaframe/ana3AIMEC/ana3AIMEC.py 70.65% <100.00%> (+1.68%) ⬆️
avaframe/in2Trans/ascUtils.py 100.00% <100.00%> (+16.12%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fso42 fso42 self-assigned this Sep 21, 2023
@fso42 fso42 added this to the Version 1.7 milestone Sep 21, 2023
@fso42 fso42 merged commit 21e0779 into master Sep 21, 2023
@fso42 fso42 deleted the fixMV branch September 21, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

confirmed Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants