Skip to content

Add L to simName for samosAT; fixes #930 [com1]#940

Merged
fso42 merged 1 commit intomasterfrom
addLfrictTypeIndicator
Nov 22, 2023
Merged

Add L to simName for samosAT; fixes #930 [com1]#940
fso42 merged 1 commit intomasterfrom
addLfrictTypeIndicator

Conversation

@fso42
Copy link
Copy Markdown
Contributor

@fso42 fso42 commented Nov 16, 2023

Only representation so far is in the simName, changing samostAT to samosATLarge is missing/ maybe not wanted?

@fso42 fso42 added enhancement New feature or request featureRequest ideas or functions that would be useful labels Nov 16, 2023
@fso42 fso42 added this to the Version 1.8 milestone Nov 16, 2023
@fso42 fso42 requested a review from awirb November 16, 2023 19:49
@fso42 fso42 self-assigned this Nov 16, 2023
@pep8speaks
Copy link
Copy Markdown

pep8speaks commented Nov 16, 2023

Hello @fso42! Thanks for updating this PR.

Line 269:5: E303 too many blank lines (2)
Line 240:6: E203 whitespace before ','
Line 132:20: E124 closing bracket does not match visual indentation
Line 100:1: E303 too many blank lines (4)

Line 701:37: E262 inline comment should start with '# '
Line 701:36: E261 at least two spaces before inline comment
Line 674:121: E501 line too long (129 > 120 characters)

Line 209:37: E711 comparison to None should be 'if cond is None:'
Line 171:37: E711 comparison to None should be 'if cond is None:'

Comment last updated at 2023-11-20 12:11:12 UTC

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (0601e3a) 73.94% compared to head (2d8b1b8) 73.93%.
Report is 6 commits behind head on master.

Files Patch % Lines
avaframe/in3Utils/geoTrans.py 97.14% 9 Missing ⚠️
avaframe/out3Plot/outDebugPlots.py 25.00% 3 Missing ⚠️
avaframe/com1DFA/DFAfunctionsCython.pyx 66.66% 1 Missing ⚠️
avaframe/com1DFA/com1DFA.py 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #940      +/-   ##
==========================================
- Coverage   73.94%   73.93%   -0.02%     
==========================================
  Files          63       63              
  Lines       14633    14618      -15     
==========================================
- Hits        10821    10808      -13     
+ Misses       3812     3810       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fso42 fso42 force-pushed the addLfrictTypeIndicator branch from 219c131 to 2d8b1b8 Compare November 20, 2023 12:11
@qlty-cloud-legacy
Copy link
Copy Markdown

Code Climate has analyzed commit 2d8b1b8 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 73.9% (0.0% change).

View more on Code Climate.

@fso42
Copy link
Copy Markdown
Contributor Author

fso42 commented Nov 21, 2023

After discussions today: leave the samosAT name for now, switch when #943 is relevant (i.e. slow phase out)

@fso42
Copy link
Copy Markdown
Contributor Author

fso42 commented Nov 22, 2023

Standardtests ok

@fso42 fso42 changed the title Add L to simName for samosAT; fixes #930 Add L to simName for samosAT; fixes #930 [com1] Nov 22, 2023
@fso42 fso42 merged commit 11b81b4 into master Nov 22, 2023
@fso42 fso42 deleted the addLfrictTypeIndicator branch November 22, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request featureRequest ideas or functions that would be useful

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants